You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by der <gi...@git.apache.org> on 2016/11/16 14:54:02 UTC
[GitHub] jena pull request #193: JENA-1260
GitHub user der opened a pull request:
https://github.com/apache/jena/pull/193
JENA-1260
Deterministic testcase for #JENA-1260. Tests the entangling of TransitiveEngine state by careful prodding of a TransitiveReasoner (avoiding full RDFS machinery) - fails prior to the fix for JENA-1260 and passes afterwards.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/der/jena JENA-1260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit a424b2191a8c3a72a8a2ef7fd922d3516755d762
Author: der <da...@epimorphics.com>
Date: 2016-11-16T14:37:52Z
Deterministic testcase for JENA-1260
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/193#discussion_r88257651
--- Diff: jena-core/src/test/java/org/apache/jena/reasoner/test/TestReasoners.java ---
@@ -333,6 +352,32 @@ public void testTransitiveBindReuse() {
}
/**
+ * Test that two transitive engines are independent.
+ * See JENA-1260
+ */
+ public void testTransitiveEngineSeparation() throws InterruptedException {
+ String NS = "http://example.com/test#";
--- End diff --
Test passes for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by der <gi...@git.apache.org>.
Github user der commented on a diff in the pull request:
https://github.com/apache/jena/pull/193#discussion_r88259429
--- Diff: jena-core/src/test/java/org/apache/jena/reasoner/test/TestRDFSReasoners.java ---
@@ -95,6 +95,7 @@ public static TestSuite suite() {
/**
* Build a single named query test
*/
+ @SuppressWarnings("unused")
private static void constructSingleQuerytests(TestSuite suite, String manifest, String test, ReasonerFactory rf, Resource config) throws IOException {
--- End diff --
Yes, sorry. I shouldn't have included that, as well as being cosmetic (and unsuccessfully cosmetic!) it's not relevant to this test case.
Would you like me to resubmit the PR without this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/193#discussion_r88263671
--- Diff: jena-core/src/test/java/org/apache/jena/reasoner/test/TestRDFSReasoners.java ---
@@ -95,6 +95,7 @@ public static TestSuite suite() {
/**
* Build a single named query test
*/
+ @SuppressWarnings("unused")
private static void constructSingleQuerytests(TestSuite suite, String manifest, String test, ReasonerFactory rf, Resource config) throws IOException {
--- End diff --
PRs are "live" - if the your branch changes so does the PR.
If you edit your branch and "push" it will change here as well.
To get rid of it, edit the file, then "git squash" or "git add" then "git commit --amend" followed by "git push --force" and it will disappear from the PR.
Or I can clean it after pulling it. This isn't a huge piece of work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/193#discussion_r88257532
--- Diff: jena-core/src/test/java/org/apache/jena/reasoner/test/TestRDFSReasoners.java ---
@@ -95,6 +95,7 @@ public static TestSuite suite() {
/**
* Build a single named query test
*/
+ @SuppressWarnings("unused")
private static void constructSingleQuerytests(TestSuite suite, String manifest, String test, ReasonerFactory rf, Resource config) throws IOException {
--- End diff --
No other change in this file.
And it introduces a warning when eclipse is set to not to have "unused" warnings. (Seems to be a "no win" situation in Eclipse.) As Jena has a lot of warnings if "unused" warnigns are turned on, for now, can be just drop this annotation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #193: JENA-1260
Posted by der <gi...@git.apache.org>.
Github user der commented on a diff in the pull request:
https://github.com/apache/jena/pull/193#discussion_r88265067
--- Diff: jena-core/src/test/java/org/apache/jena/reasoner/test/TestRDFSReasoners.java ---
@@ -95,6 +95,7 @@ public static TestSuite suite() {
/**
* Build a single named query test
*/
+ @SuppressWarnings("unused")
private static void constructSingleQuerytests(TestSuite suite, String manifest, String test, ReasonerFactory rf, Resource config) throws IOException {
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---