You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/11/11 17:52:56 UTC

Re: Review Request 27499: Introduced a callback for timer expiration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 4:52 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
  3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 

Diff: https://reviews.apache.org/r/27499/diff/


Testing
-------

This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.


Thanks,

Benjamin Hindman


Re: Review Request 27499: Introduced a callback for timer expiration.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review60820
-----------------------------------------------------------



3rdparty/libprocess/include/process/clock.hpp
<https://reviews.apache.org/r/27499/#comment102230>

    given the collection of timers only has .push_back and foreach called on it, consider a vector instead for better memory cache usage.


- Dominic Hamon


On Nov. 11, 2014, 8:52 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27499/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 8:52 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
>   3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 
> 
> Diff: https://reviews.apache.org/r/27499/diff/
> 
> 
> Testing
> -------
> 
> This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 27499: Introduced a callback for timer expiration.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review61554
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Nov. 14, 2014, 3:16 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27499/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 3:16 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
>   3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be 
> 
> Diff: https://reviews.apache.org/r/27499/diff/
> 
> 
> Testing
> -------
> 
> This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 27499: Introduced a callback for timer expiration.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/
-----------------------------------------------------------

(Updated Nov. 14, 2014, 11:16 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
  3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be 

Diff: https://reviews.apache.org/r/27499/diff/


Testing
-------

This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.


Thanks,

Benjamin Hindman


Re: Review Request 27499: Introduced a callback for timer expiration.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Nov. 11, 2014, 10:58 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/src/process.cpp, line 533
> > <https://reviews.apache.org/r/27499/diff/1/?file=747107#file747107line533>
> >
> >     How about generalizing as callbacks (a list of callbacks, listeners, observers)? Not religious about it, but would nice to follow the design pattern we are kind of moving towards http://en.wikipedia.org/wiki/Observer_pattern

Yes! We should! I added a TODO to capture that for now.


> On Nov. 11, 2014, 10:58 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/src/process.cpp, line 538
> > <https://reviews.apache.org/r/27499/diff/1/?file=747107#file747107line538>
> >
> >     If all it does is to add or set the callback, 'initialize' is a bit misleading

We update initialize to do more later in this chain.


> On Nov. 11, 2014, 10:58 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/src/process.cpp, line 962
> > <https://reviews.apache.org/r/27499/diff/1/?file=747107#file747107line962>
> >
> >     It took me a while to disambiguate variable vs function timedout(). Can we maybe name them differently?

Ah, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review60887
-----------------------------------------------------------


On Nov. 14, 2014, 11:16 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27499/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 11:16 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
>   3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be 
> 
> Diff: https://reviews.apache.org/r/27499/diff/
> 
> 
> Testing
> -------
> 
> This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 27499: Introduced a callback for timer expiration.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review60887
-----------------------------------------------------------



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27499/#comment102295>

    How about generalizing as callbacks (a list of callbacks, listeners, observers)? Not religious about it, but would nice to follow the design pattern we are kind of moving towards http://en.wikipedia.org/wiki/Observer_pattern



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27499/#comment102296>

    If all it does is to add or set the callback, 'initialize' is a bit misleading



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27499/#comment102293>

    It took me a while to disambiguate variable vs function timedout(). Can we maybe name them differently?


- Niklas Nielsen


On Nov. 11, 2014, 8:52 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27499/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 8:52 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/clock.hpp eb157cac996c48fedc69002b9d80adaba1ed85d1 
>   3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 
> 
> Diff: https://reviews.apache.org/r/27499/diff/
> 
> 
> Testing
> -------
> 
> This enables seperating the Clock specific functionality from the ProcessManager functionality so that the Clock implementation can ultimately be completely isolated.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>