You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/07 17:03:33 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request, #20642: feat: Frontend tagging
lyndsiWilliams opened a new pull request, #20642:
URL: https://github.com/apache/superset/pull/20642
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR is my POC of frontend tagging for dashboards, charts, and queries.
Note: This was for a hackathon and is currently incomplete:
- Editing tags is broken, you can double click the tag to edit but it will break when you try to press enter to submit the change.
- The query tags do not persist yet
- The list view searches do not work yet
- The welcome page has a dropdown for tags but it is not to design spec
- Excuse the mess, I did not clean up my code before pushing this up so there may be some arbitrary commented code and console.logs laying around from trying to debug editing tags.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### Global search from list view (this exists in the Charts, Dashboards, and Saved Queries list views):
#### Tags from within a chart (this exists on charts, dashboards, and the results section of queries)
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Go to a chart, dashboard, or make a query and look at the results
- Click `+ New Tag` and type a tag name
- Press enter and observe the new tag
- Go to the Welcome page and search for your tag under the Tag dropdown
- Observe your tagged item, you can click this and it will bring you to the item you tagged
- Press the `X` on the tag to delete it
- Search for your tag on the welcome page and observe that it no longer shows up since it is no longer tagged
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20642: feat: Frontend tagging
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20642:
URL: https://github.com/apache/superset/pull/20642#issuecomment-1376417302
@lyndsiWilliams Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho closed pull request #20642: feat: Frontend tagging
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho closed pull request #20642: feat: Frontend tagging
URL: https://github.com/apache/superset/pull/20642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20642: feat: Frontend tagging
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20642:
URL: https://github.com/apache/superset/pull/20642#issuecomment-1376417282
@lyndsiWilliams Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #20642: feat: Frontend tagging
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20642:
URL: https://github.com/apache/superset/pull/20642#issuecomment-1376416522
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org