You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:17:36 UTC
[GitHub] [apisix-docker] fukiki opened a new pull request #123: feat: add env variable of openssl for luarocks in dockerfile
fukiki opened a new pull request #123:
URL: https://github.com/apache/apisix-docker/pull/123
Signed-off-by: fukiki <on...@163.com>
Fix https://github.com/apache/apisix/issues/3469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] fukiki commented on pull request #123: feat: add env variable of openssl for luarocks in dockerfile
Posted by GitBox <gi...@apache.org>.
fukiki commented on pull request #123:
URL: https://github.com/apache/apisix-docker/pull/123#issuecomment-770719224
> /lgtm
>
> @fukiki only one thing that please do not use `Fix` within your comment for now, cause [apache/apisix#3469](https://github.com/apache/apisix/issues/3469) needs several PRs actually. The `Fix` would directly close that issue once this PR gets merged. `Related to` may be better. Thanks.
@imjoey I will modify it, thanks for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj merged pull request #123: feat: add env variable of openssl for luarocks in dockerfile
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #123:
URL: https://github.com/apache/apisix-docker/pull/123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org