You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2017/05/31 21:51:22 UTC
[08/16] mesos git commit: Changed `Executor` and `Framework` to class.
Changed `Executor` and `Framework` to class.
It's wierd that `Executor` and `Framework` are struct, but they have
`private` fields.
Review: https://reviews.apache.org/r/59662
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/96e08d8f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/96e08d8f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/96e08d8f
Branch: refs/heads/master
Commit: 96e08d8ff1ab2a2f3b6096a26e5c4cab7575b40d
Parents: 96ec255
Author: Jie Yu <yu...@gmail.com>
Authored: Tue May 30 15:38:09 2017 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Wed May 31 14:51:10 2017 -0700
----------------------------------------------------------------------
src/slave/slave.hpp | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/96e08d8f/src/slave/slave.hpp
----------------------------------------------------------------------
diff --git a/src/slave/slave.hpp b/src/slave/slave.hpp
index 769bb7e..9f4fc2f 100644
--- a/src/slave/slave.hpp
+++ b/src/slave/slave.hpp
@@ -100,8 +100,9 @@ namespace slave {
// Some forward declarations.
class StatusUpdateManager;
-struct Executor;
-struct Framework;
+class Executor;
+class Framework;
+
struct HttpConnection;
@@ -469,12 +470,12 @@ public:
const ContainerID& containerId);
private:
- friend struct Executor;
- friend struct Framework;
- friend struct Metrics;
-
+ friend class Executor;
+ friend class Framework;
friend class Http;
+ friend struct Metrics;
+
void _authenticate();
void authenticationTimeout(process::Future<bool> future);
@@ -683,8 +684,9 @@ std::ostream& operator<<(std::ostream& stream, const Executor& executor);
// Information describing an executor.
-struct Executor
+class Executor
{
+public:
Executor(
Slave* slave,
const FrameworkID& frameworkId,
@@ -845,8 +847,9 @@ private:
// Information about a framework.
-struct Framework
+class Framework
{
+public:
Framework(
Slave* slave,
const Flags& slaveFlags,