[GitHub] [hbase] Apache9 commented on a change in pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3640:
URL: https://github.com/apache/hbase/pull/3640#discussion_r697789517



##########
File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1760,6 +1760,10 @@ private static Op toZooKeeperOp(ZKWatcher zkw, ZKUtilOp op) throws UnsupportedOp
     }
   }
 
+  // Static boolean for warning about useMulti because we only want one warning per process
+  // instance.
+  private static boolean useMultiWarn = true;

Review comment:
       Non volatile and non atomic field which can be accessed multi threaded and we even change its value, always makes me nervous...
   
   Please at least add a simple comment to say this is not a critical thing to have race and we log it multiple times, so we do not want to use AtomicBoolean here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org