[GitHub] [pinot] ankitsultana commented on a diff in pull request #10543: Turn on v2 engine by default

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #10543:
URL: https://github.com/apache/pinot/pull/10543#discussion_r1158827932


##########
pinot-tools/src/main/java/org/apache/pinot/tools/MultistageEngineQuickStart.java:
##########
@@ -94,7 +94,6 @@ public String[] getDefaultBatchTableDirectories() {
   @Override
   public Map<String, Object> getConfigOverrides() {
     Map<String, Object> overrides = new HashMap<>(super.getConfigOverrides());
-    overrides.put("pinot.multistage.engine.enabled", "true");
     overrides.put("pinot.server.instance.currentDataTableVersion", 4);

Review Comment:
   By default data table version is 3. I think enabling multistage engine alone wouldn't be sufficient since queries will fail with data-table v3.
   
   https://github.com/apache/pinot/blob/29fd5d9cd947f936c52bd768d45ab52088abdb30/pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilderFactory.java#L37



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org