[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #4891: [Refactor] Execute 'pick rowsets' before applying for permits for a compaction task

[GitBox <gi...@apache.org>]

weizuo93 commented on a change in pull request #4891:
URL: https://github.com/apache/incubator-doris/pull/4891#discussion_r530063779



##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -28,6 +28,13 @@ BaseCompaction::BaseCompaction(TabletSharedPtr tablet, const std::string& label,
 BaseCompaction::~BaseCompaction() { }
 
 OLAPStatus BaseCompaction::compact() {
+    RETURN_NOT_OK(prepare_compact());

Review comment:
       > Who will call `BaseCompaction::compact()` now?
   
   `BaseCompaction::compact()` will still be called in "be/src/http/action/compaction_action.cpp" for `/api/compaction/run`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org