You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/04/07 18:02:15 UTC
[native-toolchain-CR] Add build script to create and publish Docker containers
Hello Hector Acosta, Joe McDonnell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15675
to review the following change.
Change subject: Add build script to create and publish Docker containers
......................................................................
Add build script to create and publish Docker containers
Adds automation to build and publish the containers used by the
Docker-based toolchain builds. These can be used by the toolchain builds
to save time by using pre-created containers instead of building the
containers on the fly. They can also be used to provide a stable,
controlled environment for the toolchain builds.
The script can also be invoked from a Jenkins build environment.
Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
---
M docker/buildall.py
A jenkins/build.sh
2 files changed, 59 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/75/15675/1
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Add build script to create and publish Docker containers
Adds automation to build and publish the containers used by the
Docker-based toolchain builds. These can be used by the toolchain builds
to save time by using pre-created containers instead of building the
containers on the fly. They can also be used to provide a stable,
controlled environment for the toolchain builds.
The script can also be invoked from a Jenkins build environment.
Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Reviewed-on: http://gerrit.cloudera.org:8080/15675
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M docker/buildall.py
A jenkins/build.sh
2 files changed, 67 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Laszlo Gaal: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh
File jenkins/build.sh:
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@21
PS1, Line 21: # the extension '.df'
This defaults to All, right?
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@26
PS1, Line 26: resutling
resulting
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@43
PS1, Line 43: impala-toolchain-*
nit: I think this should probably be quoted, otherwise it could be expanded by bash to match any files in the current directory
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:32:25 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 1: Code-Review+2
LGTM once the minor things are fixed
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:32:40 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh
File jenkins/build.sh:
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@21
PS1, Line 21: # the extension '.df'
> This defaults to All, right?
Done
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@43
PS1, Line 43:
> nit: I think this should probably be quoted, otherwise it could be expanded
Yes, of course; it was even quoted in line 52.
rewrote it to have only a single definition of the pattern.
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 22:38:09 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Hector Acosta, David Knupp, Tim Armstrong, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15675
to look at the new patch set (#2).
Change subject: Add build script to create and publish Docker containers
......................................................................
Add build script to create and publish Docker containers
Adds automation to build and publish the containers used by the
Docker-based toolchain builds. These can be used by the toolchain builds
to save time by using pre-created containers instead of building the
containers on the fly. They can also be used to provide a stable,
controlled environment for the toolchain builds.
The script can also be invoked from a Jenkins build environment.
Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
---
M docker/buildall.py
A jenkins/build.sh
2 files changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/75/15675/2
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 3: Verified+1
Verified by running the script through a matched Jenkins job in all the main modes of operation:
- building the container images from scratch
- forced rebuilding of the images
- publishing the images to a test Docker repo in a private registry, and building the toolchain inside those containers
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 08:46:47 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 03:22:50 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add build script to create and publish Docker containers
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 )
Change subject: Add build script to create and publish Docker containers
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh
File jenkins/build.sh:
http://gerrit.cloudera.org:8080/#/c/15675/1/jenkins/build.sh@26
PS1, Line 26: leave the
> resulting
Done
--
To view, visit http://gerrit.cloudera.org:8080/15675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9b9b17b14c1aa8d9512437eb6ae01f5e896c55
Gerrit-Change-Number: 15675
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 22:40:30 +0000
Gerrit-HasComments: Yes