You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/10 18:49:51 UTC
[GitHub] [solr] stillalex opened a new pull request, #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
stillalex opened a new pull request, #1283:
URL: https://github.com/apache/solr/pull/1283
Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient
https://issues.apache.org/jira/browse/SOLR-16600
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1283:
URL: https://github.com/apache/solr/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by GitBox <gi...@apache.org>.
stillalex commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1379073995
@epugh thank you for the review! I don't know much about the forbidden api check, could you link to some reading resource? just on the surface, this PR is a minor improvement on existing code, I would not add too much strictness to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1378837106
This makes sense to me, though I wonder if others might chime in who have stronger opinons? @stillalex I wonder if, for bonus points, you'd like to add this pattern to our forbidden-apis check? Seems like this change is something that we should be continuing to check for in the future? So that it doesn't come back? If you want to add it to forbidden-apis, that would be great, and let's leave it open. Otherwise, if you don't want to do that, then I'll merge once I get another LGTM! Just let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by GitBox <gi...@apache.org>.
stillalex commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1397747458
@epugh could we merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by GitBox <gi...@apache.org>.
stillalex commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1377702404
@epugh PR for SOLR-16600 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1283: SOLR-16600 Use Array instead of ObjectList when dealling with paralle…
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1283:
URL: https://github.com/apache/solr/pull/1283#issuecomment-1379488459
I've only seen it used in solr, but the gradle plugin is https://github.com/policeman-tools/forbidden-apis and it's run as part of the precommit check.
I'll leave this open for another day or so and then merge ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org