You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/07/29 23:02:17 UTC
[kudu-CR](gh-pages) Update site tool to Python 3
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16256
to review the following change.
Change subject: Update site_tool to Python 3
......................................................................
Update site_tool to Python 3
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M site_tool
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/1
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16256/1/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/16256/1/site_tool@143
PS1, Line 143: strip()
> Would it make sense to update check_output in kudu_util instead?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 15:11:28 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update site tool to Python 3
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update site_tool to Python 3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16256/1/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/16256/1/site_tool@143
PS1, Line 143: decode("utf-8")
Would it make sense to update check_output in kudu_util instead?
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Wed, 29 Jul 2020 23:41:00 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16256
to look at the new patch set (#5).
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version. Furthermore, GitHub Pages, which we use to review
rendered pages, also uses a more recent version and there can be
compatibility issues between them.
In this commit I also fix one such compatibility issue where the blog
menu item isn't active (bold) when a blog post or the blog index is
rendered.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M _tools/kudu_util.py
M site_tool
7 files changed, 95 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/5
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile
File Gemfile:
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile@24
PS4, Line 24: # We pin a slightly older version of jekyll which only requires
: # Ruby 1.9. Jekyll 3.0 requires Ruby 2.0 which is more painful to
: # install on some hosts.
> This comment should be removed since we are not pinning the jekyll version
+1
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile@39
PS4, Line 39: # Pin to an old version which doesn't require ruby 2.0.
Similar to what Bankim already pointed at above, this comment should also be removed.
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 22:13:24 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16256
to look at the new patch set (#2).
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M site_tool
6 files changed, 99 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/2
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 15:27:31 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16256
to look at the new patch set (#6).
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version. Furthermore, GitHub Pages, which we use to review
rendered pages, also uses a more recent version and there can be
compatibility issues between them.
In this commit I also fix one such compatibility issue where the blog
menu item isn't active (bold) when a blog post or the blog index is
rendered. I also fixed the releases page activeness which wasn't caused
by an incompatibility, it was incorrect before the update as well.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M _tools/kudu_util.py
M site_tool
7 files changed, 96 insertions(+), 112 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/6
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile
File Gemfile:
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile@24
PS4, Line 24: # We pin a slightly older version of jekyll which only requires
: # Ruby 1.9. Jekyll 3.0 requires Ruby 2.0 which is more painful to
: # install on some hosts.
> +1
Done
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile@39
PS4, Line 39: # Pin to an old version which doesn't require ruby 2.0.
> Similar to what Bankim already pointed at above, this comment should also b
Done
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Fri, 31 Jul 2020 10:18:42 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16256/5/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/16256/5/_includes/top_common.html@67
PS5, Line 67: <li {% if layout.active_nav == 'blog' %}class="active"{% endif %}>
Do we need layout.active_nav on all the other menu items?
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Fri, 31 Jul 2020 16:16:39 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16256
to look at the new patch set (#3).
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M _tools/kudu_util.py
M site_tool
7 files changed, 94 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/3
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Thanks for fixing this, Attila!
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile
File Gemfile:
http://gerrit.cloudera.org:8080/#/c/16256/4/Gemfile@24
PS4, Line 24: # We pin a slightly older version of jekyll which only requires
: # Ruby 1.9. Jekyll 3.0 requires Ruby 2.0 which is more painful to
: # install on some hosts.
This comment should be removed since we are not pinning the jekyll version anymore.
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 21:27:22 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16256/5/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/16256/5/_includes/top_common.html@67
PS5, Line 67: <li {% if layout.active_nav == 'blog' %}class="active"{% endif %}>
> Do we need layout.active_nav on all the other menu items?
Nope, only on this. I think it has to do with where it's set. I also fixed the releases one as the value should be download.
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Fri, 31 Jul 2020 16:34:52 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version. Furthermore, GitHub Pages, which we use to review
rendered pages, also uses a more recent version and there can be
compatibility issues between them.
In this commit I also fix one such compatibility issue where the blog
menu item isn't active (bold) when a blog post or the blog index is
rendered. I also fixed the releases page activeness which wasn't caused
by an incompatibility, it was incorrect before the update as well.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Reviewed-on: http://gerrit.cloudera.org:8080/16256
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M _tools/kudu_util.py
M site_tool
7 files changed, 96 insertions(+), 112 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16256
to look at the new patch set (#4).
Change subject: Update Jekyll and site-tool
......................................................................
Update Jekyll and site-tool
site_tool fails to publish the site on Python 3 due to shell exec
returning bytes instead of string and calling strip() on it. This patch
decodes these bytes as UTF8 strings.
This patch also updates Jekyll as the previous version doesn't run on
modern Ruby version. Furthermore, GitHub Pages, which we use to review
rendered pages, also uses a more recent version and there can be
compatibility issues between them.
In this commit I also fix one such compatibility issue where the blog
menu item isn't active (bold) when a blog post or the blog index is
rendered.
Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
---
M .gitignore
M Gemfile
M Gemfile.lock
M _config.yml
M _includes/top_common.html
M _tools/kudu_util.py
M site_tool
7 files changed, 94 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16256/4
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 5: Code-Review+2
LGTM; maybe it's worth addressing the item pointed by Grant.
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Fri, 31 Jul 2020 16:30:09 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Fri, 31 Jul 2020 16:43:42 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Update Jekyll and site-tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16256 )
Change subject: Update Jekyll and site-tool
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebab0334b1c88e5fcfa4fee5b361e6ade314e407
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 20:51:29 +0000
Gerrit-HasComments: No