You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/09 05:50:18 UTC

[GitHub] [kafka] xvrl opened a new pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

xvrl opened a new pull request #9400:
URL: https://github.com/apache/kafka/pull/9400


   rename internal classes and methods for KIP-629


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-705984805


   Is ```allowList``` more suitable to replace ```whiteList```?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] gwenshap closed pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
gwenshap closed pull request #9400:
URL: https://github.com/apache/kafka/pull/9400


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] xvrl commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-706266330


   jdk11 failures seem unrelated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] xvrl commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-705987912


   @chia7712 this was already discussed as part of KIP-629. The term "include" was chosen to align with existing configs we already had. Please see the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-629:+Use+racially+neutral+terms+in+our+codebase) and [the mailing list discussion](https://lists.apache.org/thread.html/rbe19a71644c85c53de7ea5cfa00e4c90f530332f09758f24709b81f6%40%3Cdev.kafka.apache.org%3E)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] xvrl commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-705987912


   @chia7712 this was already discussed as part of KIP-629. The term "include" was chosen to align with existing configs we already had. Please see the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-629:+Use+racially+neutral+terms+in+our+codebase) and [the mailing list discussion](https://lists.apache.org/thread.html/rbe19a71644c85c53de7ea5cfa00e4c90f530332f09758f24709b81f6%40%3Cdev.kafka.apache.org%3E)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-705984805






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9400:
URL: https://github.com/apache/kafka/pull/9400#issuecomment-705989392


   > this was already discussed as part of KIP-629. The term "include" was chosen to align with existing configs we already had. Please see the KIP and the mailing list discussion
   
   Got it. thanks for the information!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org