You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/08 03:50:04 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #23379: Add pipeline E2E IT log and make sure they are serial

sandynz commented on code in PR #23379:
URL: https://github.com/apache/shardingsphere/pull/23379#discussion_r1064077923


##########
test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/base/PipelineBaseE2EIT.java:
##########
@@ -108,11 +108,12 @@ public abstract class PipelineBaseE2EIT {
     
     private Thread increaseTaskThread;
     
-    public PipelineBaseE2EIT(final PipelineTestParameter testParam) {
-        databaseType = testParam.getDatabaseType();
+    public PipelineBaseE2EIT(final PipelineTestParameter testParameter) {

Review Comment:
   Based on Code of Conduct, `testParameter` could be `testParam`, so it's not necessary to rename it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org