You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/22 09:50:26 UTC

[GitHub] [trafficserver] c-taylor opened a new issue #7973: disable_freelist flag '-f' appears to do nothing

c-taylor opened a new issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973


   https://github.com/apache/trafficserver/blob/f8ec81d7b8c28ca00ceedff282a76af47314dfcb/src/traffic_server/traffic_server.cc#L201
   
   The '-f' flag and all documentation exists, but it appears to have no action.
   This should be removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] c-taylor commented on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
c-taylor commented on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870438290


   Thanks for looking at this, I think we can file it under "fool in a hurry".
   
   I had been testing with '-F' and reading the behaviour of `cmd_disable_pfreelist` in ProxyAllocator.cc and I_ProxyAllocator.h.
   I missed `ink_freelist_init_ops`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] c-taylor closed issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
c-taylor closed issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 commented on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
duke8253 commented on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870116063


   Hmm, which version are you on? Can you find this line in `traffic_server.cc`
   ```
   ink_freelist_init_ops(cmd_disable_freelist, cmd_disable_pfreelist);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 commented on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
duke8253 commented on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870119524


   Pretty sure it's working as intended, `-f` disables freelist only in Class Allocators, `-F` includes `-f`, and also disables it in Proxy Allocators.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 commented on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
duke8253 commented on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870116063






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 edited a comment on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
duke8253 edited a comment on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870119524


   Pretty sure it's working as intended, `-f` disables freelist only in Class Allocators, `-F` includes `-f`, and also disables it in Proxy Allocators. #4720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] c-taylor commented on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
c-taylor commented on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870438290


   Thanks for looking at this, I think we can file it under "fool in a hurry".
   
   I had been testing with '-F' and reading the behaviour of `cmd_disable_pfreelist` in ProxyAllocator.cc and I_ProxyAllocator.h.
   I missed `ink_freelist_init_ops`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] duke8253 edited a comment on issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
duke8253 edited a comment on issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973#issuecomment-870119524


   Pretty sure it's working as intended, `-f` disables freelist only in Class Allocators, `-F` includes `-f`, and also disables it in Proxy Allocators. #4720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] c-taylor closed issue #7973: disable_freelist flag '-f' appears to do nothing

Posted by GitBox <gi...@apache.org>.
c-taylor closed issue #7973:
URL: https://github.com/apache/trafficserver/issues/7973


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org