You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by we...@apache.org on 2019/01/17 21:40:27 UTC
samza git commit: SAMZA-2076: RocksDbTableDescriptor should use Long
type for TTL
Repository: samza
Updated Branches:
refs/heads/master 4289ca91d -> 193fd272c
SAMZA-2076: RocksDbTableDescriptor should use Long type for TTL
Samza uses millisec as config value, while in rocksDB it's defined as int32. It's currently defined as integer in RocksDbTableDescriptor, the range isn't large enough to match, and it should be of Long type.
Author: Wei Song <ws...@linkedin.com>
Reviewers: Hai Lu <ha...@linkedin.com>
Closes #887 from weisong44/SAMZA-2076
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/193fd272
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/193fd272
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/193fd272
Branch: refs/heads/master
Commit: 193fd272c931a09305ceced18205e6c4f7c311c7
Parents: 4289ca9
Author: Wei Song <ws...@linkedin.com>
Authored: Thu Jan 17 13:40:21 2019 -0800
Committer: Wei Song <ws...@linkedin.com>
Committed: Thu Jan 17 13:40:21 2019 -0800
----------------------------------------------------------------------
.../samza/storage/kv/descriptors/RocksDbTableDescriptor.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/193fd272/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/descriptors/RocksDbTableDescriptor.java
----------------------------------------------------------------------
diff --git a/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/descriptors/RocksDbTableDescriptor.java b/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/descriptors/RocksDbTableDescriptor.java
index ce2b8f6..0703317 100644
--- a/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/descriptors/RocksDbTableDescriptor.java
+++ b/samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/descriptors/RocksDbTableDescriptor.java
@@ -55,7 +55,7 @@ public class RocksDbTableDescriptor<K, V> extends LocalTableDescriptor<K, V, Roc
private Integer cacheSize;
private Integer writeBufferSize;
private Integer blockSize;
- private Integer ttl;
+ private Long ttl;
private Integer numWriteBuffers;
private Integer maxLogFileSize;
private Integer numLogFilesToKeep;
@@ -198,7 +198,7 @@ public class RocksDbTableDescriptor<K, V> extends LocalTableDescriptor<K, V, Roc
* @param ttl the time to live in milliseconds
* @return this table descriptor instance
*/
- public RocksDbTableDescriptor<K, V> withTtl(int ttl) {
+ public RocksDbTableDescriptor<K, V> withTtl(long ttl) {
this.ttl = ttl;
return this;
}