You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/11/21 20:01:21 UTC
[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8624
Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples
......................................................................
[DOCS] Correct bit patterns in comments for shiftright() examples
Looks like I reused the same comment in 3 places with a RHS of
00000000, and filled in the right bit pattern on the LHS but
not the RHS. The actual code and output are correct.
Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
---
M docs/topics/impala_bit_functions.xml
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/8624/1
--
To view, visit http://gerrit.cloudera.org:8080/8624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Gerrit-Change-Number: 8624
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8624 )
Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/176/
--
To view, visit http://gerrit.cloudera.org:8080/8624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Gerrit-Change-Number: 8624
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 18:58:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8624 )
Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples
......................................................................
[DOCS] Correct bit patterns in comments for shiftright() examples
Looks like I reused the same comment in 3 places with a RHS of
00000000, and filled in the right bit pattern on the LHS but
not the RHS. The actual code and output are correct.
Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Reviewed-on: http://gerrit.cloudera.org:8080/8624
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_bit_functions.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Gerrit-Change-Number: 8624
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8624 )
Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Gerrit-Change-Number: 8624
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 19:21:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Correct bit patterns in comments for shiftright() examples
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8624 )
Change subject: [DOCS] Correct bit patterns in comments for shiftright() examples
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1bc00e4c8d1ae3352e18a8df95745d9c9b5ea6
Gerrit-Change-Number: 8624
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Nov 2017 20:02:32 +0000
Gerrit-HasComments: No