You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Kasun Indrasiri <ka...@gmail.com> on 2011/12/13 11:01:57 UTC
Synapse trunk is upgraded to commons-vfs2
Hi devs,
I've completed the upgrading of commons vfs to version 2.0. Also add the
required fixes with synapse patching mechanism. [1]
[1]
https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
Thanks.
--
Kasun Indrasiri
Senior Software Engineer,
WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
Blog : http://kasunpanorama.blogspot.com/
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Kasun Indrasiri <ka...@gmail.com>.
Modified the synapse patching process which was based on jars that which
were added to /patches/jars.
Now the patches are created based on the required source files stored in
patches/src during compile time. Also removed existing redundant patches
from /patches/jars.
On Wed, Dec 14, 2011 at 11:04 AM, Kasun Indrasiri <ka...@gmail.com>wrote:
>
>
> On Wed, Dec 14, 2011 at 10:52 AM, Ruwan Linton <ru...@gmail.com>wrote:
>
>> to clarify, I originally meant this approach, and I missed how this has
>> actually been implemented.
>>
>> <quote from thread "Upgrading to Commons VFS 2">
>> So the commons-vfs patch will be a small maven module with just the
>> patched classes using the released artifact as a compile time dependency
>> and the synapse distribution build will need to copy that tiny patch into
>> the patches directory of the synapse lib.
>> </quote>
>>
>> Kasun, will you be able to do the necessary changes?
>>
>> Yeah, I'm working on the required changes. However, already we have[1] in
> synapse patches which also doesn't adhere to the requirements mentioned by
> Andreas. (Anyway we are going to get rid of this httpcore patch as the
> patch is already available in the 4.1 release)
>
> [1]
> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/httpcore-nio-4.0-patch-httpcore-193.jar
>
>
> Thanks,
>> Ruwan
>>
>>
>> On Wed, Dec 14, 2011 at 10:44 AM, Ruwan Linton <ru...@gmail.com>wrote:
>>
>>> +1
>>>
>>> Ruwan
>>>
>>>
>>> On Wed, Dec 14, 2011 at 10:18 AM, Hiranya Jayathilaka <
>>> hiranya911@gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen <
>>>> andreas.veithen@gmail.com> wrote:
>>>>
>>>>> -1
>>>>>
>>>>> I think that this approach is incompatible with the ASL because we
>>>>> would distribute binaries (that are not 3rd party binaries with an
>>>>> appropriate license) without distributing the corresponding source
>>>>> code. I think that the patch should be produced from sources during
>>>>> the Synapse build.
>>>>>
>>>>
>>>> I think you're right. We should put the patched source files under
>>>> modules/patches. Not the binary.
>>>>
>>>>
>>>>>
>>>>> Andreas
>>>>>
>>>>> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com>
>>>>> wrote:
>>>>> > Hi devs,
>>>>> >
>>>>> > I've completed the upgrading of commons vfs to version 2.0. Also add
>>>>> the
>>>>> > required fixes with synapse patching mechanism. [1]
>>>>> >
>>>>> > [1]
>>>>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>>>>> >
>>>>> > Thanks.
>>>>> > --
>>>>> > Kasun Indrasiri
>>>>> > Senior Software Engineer,
>>>>> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>>>>> > Blog : http://kasunpanorama.blogspot.com/
>>>>> >
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>>>>> For additional commands, e-mail: dev-help@synapse.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Hiranya Jayathilaka
>>>> Associate Technical Lead;
>>>> WSO2 Inc.; http://wso2.org
>>>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>>> Blog: http://techfeast-hiranya.blogspot.com
>>>>
>>>
>>>
>>>
>>> --
>>> Ruwan Linton
>>> Member, Apache Software Foundation; http://www.apache.org
>>> Director of Engineering; http://adroitlogic.org
>>>
>>> phone: +94 11 282 7532
>>> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
>>> blog: http://blog.ruwan.org
>>> linkedin: http://www.linkedin.com/in/ruwanlinton
>>> google: http://www.google.com/profiles/ruwan.linton
>>> tweet: http://twitter.com/ruwanlinton
>>>
>>>
>>
>>
>> --
>> Ruwan Linton
>> Member, Apache Software Foundation; http://www.apache.org
>> Director of Engineering; http://adroitlogic.org
>>
>> phone: +94 11 282 7532
>> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
>> blog: http://blog.ruwan.org
>> linkedin: http://www.linkedin.com/in/ruwanlinton
>> google: http://www.google.com/profiles/ruwan.linton
>> tweet: http://twitter.com/ruwanlinton
>>
>>
>
>
> --
> Kasun Indrasiri
> Associate Technical Lead,
>
> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> Blog : http://kasunpanorama.blogspot.com/
>
>
--
Kasun Indrasiri
Associate Technical Lead,
WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
Blog : http://kasunpanorama.blogspot.com/
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Kasun Indrasiri <ka...@gmail.com>.
On Wed, Dec 14, 2011 at 10:52 AM, Ruwan Linton <ru...@gmail.com>wrote:
> to clarify, I originally meant this approach, and I missed how this has
> actually been implemented.
>
> <quote from thread "Upgrading to Commons VFS 2">
> So the commons-vfs patch will be a small maven module with just the
> patched classes using the released artifact as a compile time dependency
> and the synapse distribution build will need to copy that tiny patch into
> the patches directory of the synapse lib.
> </quote>
>
> Kasun, will you be able to do the necessary changes?
>
> Yeah, I'm working on the required changes. However, already we have[1] in
synapse patches which also doesn't adhere to the requirements mentioned by
Andreas. (Anyway we are going to get rid of this httpcore patch as the
patch is already available in the 4.1 release)
[1]
https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/httpcore-nio-4.0-patch-httpcore-193.jar
Thanks,
> Ruwan
>
>
> On Wed, Dec 14, 2011 at 10:44 AM, Ruwan Linton <ru...@gmail.com>wrote:
>
>> +1
>>
>> Ruwan
>>
>>
>> On Wed, Dec 14, 2011 at 10:18 AM, Hiranya Jayathilaka <
>> hiranya911@gmail.com> wrote:
>>
>>>
>>>
>>> On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen <
>>> andreas.veithen@gmail.com> wrote:
>>>
>>>> -1
>>>>
>>>> I think that this approach is incompatible with the ASL because we
>>>> would distribute binaries (that are not 3rd party binaries with an
>>>> appropriate license) without distributing the corresponding source
>>>> code. I think that the patch should be produced from sources during
>>>> the Synapse build.
>>>>
>>>
>>> I think you're right. We should put the patched source files under
>>> modules/patches. Not the binary.
>>>
>>>
>>>>
>>>> Andreas
>>>>
>>>> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com>
>>>> wrote:
>>>> > Hi devs,
>>>> >
>>>> > I've completed the upgrading of commons vfs to version 2.0. Also add
>>>> the
>>>> > required fixes with synapse patching mechanism. [1]
>>>> >
>>>> > [1]
>>>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>>>> >
>>>> > Thanks.
>>>> > --
>>>> > Kasun Indrasiri
>>>> > Senior Software Engineer,
>>>> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>>>> > Blog : http://kasunpanorama.blogspot.com/
>>>> >
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>>>> For additional commands, e-mail: dev-help@synapse.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> Hiranya Jayathilaka
>>> Associate Technical Lead;
>>> WSO2 Inc.; http://wso2.org
>>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>> Blog: http://techfeast-hiranya.blogspot.com
>>>
>>
>>
>>
>> --
>> Ruwan Linton
>> Member, Apache Software Foundation; http://www.apache.org
>> Director of Engineering; http://adroitlogic.org
>>
>> phone: +94 11 282 7532
>> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
>> blog: http://blog.ruwan.org
>> linkedin: http://www.linkedin.com/in/ruwanlinton
>> google: http://www.google.com/profiles/ruwan.linton
>> tweet: http://twitter.com/ruwanlinton
>>
>>
>
>
> --
> Ruwan Linton
> Member, Apache Software Foundation; http://www.apache.org
> Director of Engineering; http://adroitlogic.org
>
> phone: +94 11 282 7532
> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
> blog: http://blog.ruwan.org
> linkedin: http://www.linkedin.com/in/ruwanlinton
> google: http://www.google.com/profiles/ruwan.linton
> tweet: http://twitter.com/ruwanlinton
>
>
--
Kasun Indrasiri
Associate Technical Lead,
WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
Blog : http://kasunpanorama.blogspot.com/
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Ruwan Linton <ru...@gmail.com>.
to clarify, I originally meant this approach, and I missed how this has
actually been implemented.
<quote from thread "Upgrading to Commons VFS 2">
So the commons-vfs patch will be a small maven module with just the patched
classes using the released artifact as a compile time dependency and the
synapse distribution build will need to copy that tiny patch into the
patches directory of the synapse lib.
</quote>
Kasun, will you be able to do the necessary changes?
Thanks,
Ruwan
On Wed, Dec 14, 2011 at 10:44 AM, Ruwan Linton <ru...@gmail.com>wrote:
> +1
>
> Ruwan
>
>
> On Wed, Dec 14, 2011 at 10:18 AM, Hiranya Jayathilaka <
> hiranya911@gmail.com> wrote:
>
>>
>>
>> On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen <
>> andreas.veithen@gmail.com> wrote:
>>
>>> -1
>>>
>>> I think that this approach is incompatible with the ASL because we
>>> would distribute binaries (that are not 3rd party binaries with an
>>> appropriate license) without distributing the corresponding source
>>> code. I think that the patch should be produced from sources during
>>> the Synapse build.
>>>
>>
>> I think you're right. We should put the patched source files under
>> modules/patches. Not the binary.
>>
>>
>>>
>>> Andreas
>>>
>>> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com>
>>> wrote:
>>> > Hi devs,
>>> >
>>> > I've completed the upgrading of commons vfs to version 2.0. Also add
>>> the
>>> > required fixes with synapse patching mechanism. [1]
>>> >
>>> > [1]
>>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>>> >
>>> > Thanks.
>>> > --
>>> > Kasun Indrasiri
>>> > Senior Software Engineer,
>>> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>>> > Blog : http://kasunpanorama.blogspot.com/
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>>> For additional commands, e-mail: dev-help@synapse.apache.org
>>>
>>>
>>
>>
>> --
>> Hiranya Jayathilaka
>> Associate Technical Lead;
>> WSO2 Inc.; http://wso2.org
>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>> Blog: http://techfeast-hiranya.blogspot.com
>>
>
>
>
> --
> Ruwan Linton
> Member, Apache Software Foundation; http://www.apache.org
> Director of Engineering; http://adroitlogic.org
>
> phone: +94 11 282 7532
> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
> blog: http://blog.ruwan.org
> linkedin: http://www.linkedin.com/in/ruwanlinton
> google: http://www.google.com/profiles/ruwan.linton
> tweet: http://twitter.com/ruwanlinton
>
>
--
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org
phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Ruwan Linton <ru...@gmail.com>.
+1
Ruwan
On Wed, Dec 14, 2011 at 10:18 AM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
>
>
> On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen <
> andreas.veithen@gmail.com> wrote:
>
>> -1
>>
>> I think that this approach is incompatible with the ASL because we
>> would distribute binaries (that are not 3rd party binaries with an
>> appropriate license) without distributing the corresponding source
>> code. I think that the patch should be produced from sources during
>> the Synapse build.
>>
>
> I think you're right. We should put the patched source files under
> modules/patches. Not the binary.
>
>
>>
>> Andreas
>>
>> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com>
>> wrote:
>> > Hi devs,
>> >
>> > I've completed the upgrading of commons vfs to version 2.0. Also add the
>> > required fixes with synapse patching mechanism. [1]
>> >
>> > [1]
>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>> >
>> > Thanks.
>> > --
>> > Kasun Indrasiri
>> > Senior Software Engineer,
>> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>> > Blog : http://kasunpanorama.blogspot.com/
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>> For additional commands, e-mail: dev-help@synapse.apache.org
>>
>>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
--
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org
phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Hiranya Jayathilaka <hi...@gmail.com>.
On Wed, Dec 14, 2011 at 12:34 AM, Andreas Veithen <andreas.veithen@gmail.com
> wrote:
> -1
>
> I think that this approach is incompatible with the ASL because we
> would distribute binaries (that are not 3rd party binaries with an
> appropriate license) without distributing the corresponding source
> code. I think that the patch should be produced from sources during
> the Synapse build.
>
I think you're right. We should put the patched source files under
modules/patches. Not the binary.
>
> Andreas
>
> On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com> wrote:
> > Hi devs,
> >
> > I've completed the upgrading of commons vfs to version 2.0. Also add the
> > required fixes with synapse patching mechanism. [1]
> >
> > [1]
> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
> >
> > Thanks.
> > --
> > Kasun Indrasiri
> > Senior Software Engineer,
> > WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> > Blog : http://kasunpanorama.blogspot.com/
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Andreas Veithen <an...@gmail.com>.
-1
I think that this approach is incompatible with the ASL because we
would distribute binaries (that are not 3rd party binaries with an
appropriate license) without distributing the corresponding source
code. I think that the patch should be produced from sources during
the Synapse build.
Andreas
On Tue, Dec 13, 2011 at 11:01, Kasun Indrasiri <ka...@gmail.com> wrote:
> Hi devs,
>
> I've completed the upgrading of commons vfs to version 2.0. Also add the
> required fixes with synapse patching mechanism. [1]
>
> [1] https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>
> Thanks.
> --
> Kasun Indrasiri
> Senior Software Engineer,
> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> Blog : http://kasunpanorama.blogspot.com/
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Ruwan Linton <ru...@gmail.com>.
+1,
Anyway now we have a sub-optimal solution with only the patch being custom,
not the complete commons-vfs lib.
Thanks,
Ruwan
On Tue, Dec 13, 2011 at 4:27 PM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
>
>
> On Tue, Dec 13, 2011 at 3:31 PM, Kasun Indrasiri <ka...@gmail.com>wrote:
>
>> Hi devs,
>>
>> I've completed the upgrading of commons vfs to version 2.0. Also add the
>> required fixes with synapse patching mechanism. [1]
>>
>
> Great :)
>
> I haven't heard back from the commons-vfs team. So I guess we'll have to
> live with this patch for a while.
>
> Thanks,
> Hiranya
>
>
>>
>> [1]
>> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>>
>> Thanks.
>> --
>> Kasun Indrasiri
>> Senior Software Engineer,
>> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
>> Blog : http://kasunpanorama.blogspot.com/
>>
>>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
--
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org
phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton
Re: Synapse trunk is upgraded to commons-vfs2
Posted by Hiranya Jayathilaka <hi...@gmail.com>.
On Tue, Dec 13, 2011 at 3:31 PM, Kasun Indrasiri <ka...@gmail.com> wrote:
> Hi devs,
>
> I've completed the upgrading of commons vfs to version 2.0. Also add the
> required fixes with synapse patching mechanism. [1]
>
Great :)
I haven't heard back from the commons-vfs team. So I guess we'll have to
live with this patch for a while.
Thanks,
Hiranya
>
> [1]
> https://svn.apache.org/repos/asf/synapse/trunk/java/modules/patches/jars/commons-vfs2-2.0-vfs-178.jar
>
> Thanks.
> --
> Kasun Indrasiri
> Senior Software Engineer,
> WSO2 Inc. - "Lean . Enterprise . Middleware" - http://www.wso2.com/
> Blog : http://kasunpanorama.blogspot.com/
>
>
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com