You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/16 14:30:37 UTC

[GitHub] [submarine] atosystem commented on a change in pull request #836: SUBMARINE-1140. Some fixes for auto generating python from swagger

atosystem commented on a change in pull request #836:
URL: https://github.com/apache/submarine/pull/836#discussion_r770589362



##########
File path: dev-support/pysubmarine/gen-sdk.sh
##########
@@ -55,13 +61,15 @@ java -jar ${SWAGGER_CODEGEN_JAR} generate \
      -c ${SWAGGER_CODEGEN_CONF}
 
 echo "Insert apache license at the top of file ..."
-for filename in $(find ${SDK_OUTPUT_PATH}/submarine/experiment -type f); do
+for filename in $(find ${SDK_OUTPUT_PATH}/submarine/${API_COMPONENT} -type f); do
   echo "$filename"
-  sed -i -e '1 e cat license-header.txt' "$filename"

Review comment:
       I give up using `sed` since there is some differences between the usage of BSD and Linux version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org