You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Charles Reiss (Created) (JIRA)" <ji...@apache.org> on 2012/03/18 05:40:10 UTC
[jira] [Created] (MESOS-167) Make API names consistent
Make API names consistent
-------------------------
Key: MESOS-167
URL: https://issues.apache.org/jira/browse/MESOS-167
Project: Mesos
Issue Type: Improvement
Reporter: Charles Reiss
benh (and others?) have suggested that we should adjust some names in the API for consistency, ideally before we release and need to keep the API stable:
- ResourceRequest to Request (for consistency with Offer)
- TaskDescription to TaskInfo (for consistency with SlaveInfo, ExecutorInfo, FrameworkInfo, etc.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-167) Make API names consistent
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233073#comment-13233073 ]
jiraposter@reviews.apache.org commented on MESOS-167:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4395/#review6101
-----------------------------------------------------------
Ship it!
Thanks so much for this Charles ... one of the last API things we wanted to do before the release!
- Benjamin
On 2012-03-18 04:52:16, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4395/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-18 04:52:16)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Changes TaskDescription -> TaskInfo, ResourceRequest -> Request.
bq.
bq. Does _not_ update the hadoop patch (I think the obvious text substitution will work, but I haven't been able to test it.)
bq.
bq.
bq. This addresses bug MESOS-167.
bq. https://issues.apache.org/jira/browse/MESOS-167
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/executor.hpp d09e007
bq. include/mesos/mesos.proto 5f034a6
bq. include/mesos/scheduler.hpp 1e858aa
bq. src/common/type_utils.hpp 537de1a
bq. src/examples/java/TestExecutor.java c911865
bq. src/examples/java/TestFramework.java 589c79e
bq. src/examples/java/TestMultipleExecutorsFramework.java 048d52d
bq. src/examples/long_lived_executor.cpp b890047
bq. src/examples/long_lived_framework.cpp 0d6140e
bq. src/examples/no_executor_framework.cpp cdba88d
bq. src/examples/python/test_framework.py c8164a1
bq. src/examples/test_executor.cpp a99aa57
bq. src/examples/test_framework.cpp 3c6f34f
bq. src/exec/exec.cpp dcb9efa
bq. src/java/jni/construct.cpp a9033ea
bq. src/java/jni/convert.cpp bd187d0
bq. src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 7dd94c1
bq. src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 2446ac2
bq. src/java/src/org/apache/mesos/Executor.java 55d1142
bq. src/java/src/org/apache/mesos/MesosSchedulerDriver.java ce578d4
bq. src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
bq. src/launcher/executor.cpp aac1053
bq. src/master/allocator.hpp 1ac435b
bq. src/master/master.hpp 53551b0
bq. src/master/master.cpp 0222bb2
bq. src/master/simple_allocator.hpp d54b68e
bq. src/master/simple_allocator.cpp b01d588
bq. src/messages/messages.proto 11a2c41
bq. src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
bq. src/python/native/proxy_executor.hpp 4ad5035
bq. src/python/native/proxy_executor.cpp 06ea44a
bq. src/scaling/scaling_exec.py 4b56360
bq. src/scaling/scaling_sched.py c94fdab
bq. src/sched/sched.cpp 2988202
bq. src/slave/slave.hpp de304cb
bq. src/slave/slave.cpp ddd1874
bq. src/tests/fault_tolerance_tests.cpp 3ee55f7
bq. src/tests/master_tests.cpp 025ed54
bq. src/tests/resource_offers_tests.cpp 864c9a6
bq. src/tests/utils.hpp d7bafb4
bq.
bq. Diff: https://reviews.apache.org/r/4395/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Make API names consistent
> -------------------------
>
> Key: MESOS-167
> URL: https://issues.apache.org/jira/browse/MESOS-167
> Project: Mesos
> Issue Type: Improvement
> Reporter: Charles Reiss
>
> benh (and others?) have suggested that we should adjust some names in the API for consistency, ideally before we release and need to keep the API stable:
> - ResourceRequest to Request (for consistency with Offer)
> - TaskDescription to TaskInfo (for consistency with SlaveInfo, ExecutorInfo, FrameworkInfo, etc.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-167) Make API names consistent
Posted by "Charles Reiss (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss resolved MESOS-167.
---------------------------------
Resolution: Fixed
I believe this is fixed by r1303185 and r1303188.
> Make API names consistent
> -------------------------
>
> Key: MESOS-167
> URL: https://issues.apache.org/jira/browse/MESOS-167
> Project: Mesos
> Issue Type: Improvement
> Reporter: Charles Reiss
>
> benh (and others?) have suggested that we should adjust some names in the API for consistency, ideally before we release and need to keep the API stable:
> - ResourceRequest to Request (for consistency with Offer)
> - TaskDescription to TaskInfo (for consistency with SlaveInfo, ExecutorInfo, FrameworkInfo, etc.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-167) Make API names consistent
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232161#comment-13232161 ]
jiraposter@reviews.apache.org commented on MESOS-167:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4395/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Summary
-------
Changes TaskDescription -> TaskInfo, ResourceRequest -> Request.
Does _not_ update the hadoop patch (I think the obvious text substitution will work, but I haven't been able to test it.)
This addresses bug MESOS-167.
https://issues.apache.org/jira/browse/MESOS-167
Diffs
-----
include/mesos/executor.hpp d09e007
include/mesos/mesos.proto 5f034a6
include/mesos/scheduler.hpp 1e858aa
src/common/type_utils.hpp 537de1a
src/examples/java/TestExecutor.java c911865
src/examples/java/TestFramework.java 589c79e
src/examples/java/TestMultipleExecutorsFramework.java 048d52d
src/examples/long_lived_executor.cpp b890047
src/examples/long_lived_framework.cpp 0d6140e
src/examples/no_executor_framework.cpp cdba88d
src/examples/python/test_framework.py c8164a1
src/examples/test_executor.cpp a99aa57
src/examples/test_framework.cpp 3c6f34f
src/exec/exec.cpp dcb9efa
src/java/jni/construct.cpp a9033ea
src/java/jni/convert.cpp bd187d0
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 7dd94c1
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 2446ac2
src/java/src/org/apache/mesos/Executor.java 55d1142
src/java/src/org/apache/mesos/MesosSchedulerDriver.java ce578d4
src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
src/launcher/executor.cpp aac1053
src/master/allocator.hpp 1ac435b
src/master/master.hpp 53551b0
src/master/master.cpp 0222bb2
src/master/simple_allocator.hpp d54b68e
src/master/simple_allocator.cpp b01d588
src/messages/messages.proto 11a2c41
src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
src/python/native/proxy_executor.hpp 4ad5035
src/python/native/proxy_executor.cpp 06ea44a
src/scaling/scaling_exec.py 4b56360
src/scaling/scaling_sched.py c94fdab
src/sched/sched.cpp 2988202
src/slave/slave.hpp de304cb
src/slave/slave.cpp ddd1874
src/tests/fault_tolerance_tests.cpp 3ee55f7
src/tests/master_tests.cpp 025ed54
src/tests/resource_offers_tests.cpp 864c9a6
src/tests/utils.hpp d7bafb4
Diff: https://reviews.apache.org/r/4395/diff
Testing
-------
make check
Thanks,
Charles
> Make API names consistent
> -------------------------
>
> Key: MESOS-167
> URL: https://issues.apache.org/jira/browse/MESOS-167
> Project: Mesos
> Issue Type: Improvement
> Reporter: Charles Reiss
>
> benh (and others?) have suggested that we should adjust some names in the API for consistency, ideally before we release and need to keep the API stable:
> - ResourceRequest to Request (for consistency with Offer)
> - TaskDescription to TaskInfo (for consistency with SlaveInfo, ExecutorInfo, FrameworkInfo, etc.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira