You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/20 19:14:15 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1159: add tutorial for customized view
zhangmeng916 opened a new pull request #1159:
URL: https://github.com/apache/helix/pull/1159
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1144
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Add tutorial for how to use customized view
### Tests
- [X] The following tests are written for this issue:
mvn site:site
mvn site:stage
passed, and the generated website is checked
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #1159: add tutorial for customized view
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1159:
URL: https://github.com/apache/helix/pull/1159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1159: add tutorial for customized view
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1159:
URL: https://github.com/apache/helix/pull/1159#issuecomment-661314378
This PR is ready to be merged, approved by @dasahcc
Final commit message:
Add tutorial for customized view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org