You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/08/24 08:15:29 UTC
[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #5213: HDDS-9161. Recon Pipelines datanode columns search does not work
smitajoshi12 commented on code in PR #5213:
URL: https://github.com/apache/ozone/pull/5213#discussion_r1303971178
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/columnSearch.tsx:
##########
@@ -69,8 +69,15 @@ class ColumnSearch extends React.PureComponent {
filterIcon: (filtered: boolean) => (
<Icon type='search' style={{color: filtered ? '#1890ff' : undefined}}/>
),
- onFilter: (value: string, record: any) =>
- record[dataIndex].toString().toLowerCase().includes(value.toLowerCase()),
+ onFilter: (value: string, record: any) => {
+ if (record[dataIndex]) {
+ return typeof (record[dataIndex]) == 'object' ? Object.values(...record[dataIndex]).toString().toLowerCase().includes(value.toLowerCase())
Review Comment:
@devabhishekpal Updated with Latest Commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org