[GitHub] [spark] amaliujia commented on a diff in pull request #38578: [SPARK-41064][CONNECT][PYTHON] Implement `DataFrame.crosstab` and `DataFrame.stat.crosstab`

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38578:
URL: https://github.com/apache/spark/pull/38578#discussion_r1017575255


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -272,5 +273,13 @@ message StatFunction {
   message Summary {
     repeated string statistics = 1;
   }
+
+  // StatFunctions.crossTabulate
+  message CrossTabulate {

Review Comment:
   Can we add a bit more comments on such proto? Basically proto is also API that someone will read to understand the contract.
   
   Beam's implementation offers a good example of comments for proto: https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org