You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org> on 2006/09/26 16:34:51 UTC

[jira] Created: (ADFFACES-198) Making renderer APIs public

Making renderer APIs public
---------------------------

                 Key: ADFFACES-198
                 URL: http://issues.apache.org/jira/browse/ADFFACES-198
             Project: MyFaces ADF-Faces
          Issue Type: Improvement
            Reporter: Matthias Weßendorf
         Assigned To: Adam Winer
            Priority: Minor


quote from Adam Winer of the dev list:

The goal is to move APIs out of trinidad-impl and into trinidad-api, but
a number of the desired APIs pulled in a lot of code that really shouldn't
be made public.  So, a bunch of refactoring was called for, introducing
some pure abstract base classes with reduced functionality, or sometimes
just eliminating dependencies altogether.

My planned next step is to move the following APIs over, with
proposed package names (all under org.apache.myfaces.trinidad,
of course)

 * render.RenderingContext
 * render.PartialPageContext
 * render.LocaleContext
 * render.FormData
 * skin.Skin
 * skin.Icon

Option 2 I can think of is to use context.RenderingContext instead
of render.RenderingContext (and likewise for all the first four).

After that, the only classes I'm itching to make public are CoreRenderer
and RenderUtils, both of which would go into o.a.m.t.render.  After
that, I can think of a bunch of candidates, like some of the output
utility functions in core.xhtml, maybe RenderKitDecorator, etc.,
but we can take those on more slowly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-198) Making renderer APIs public

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-198:
----------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> Making renderer APIs public
> ---------------------------
>
>                 Key: ADFFACES-198
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-198
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>    Affects Versions: 1.0.0-incubating-core
>            Reporter: Matthias Weßendorf
>         Assigned To: Adam Winer
>            Priority: Minor
>             Fix For: 1.0.0-incubating-core
>
>
> quote from Adam Winer of the dev list:
> The goal is to move APIs out of trinidad-impl and into trinidad-api, but
> a number of the desired APIs pulled in a lot of code that really shouldn't
> be made public.  So, a bunch of refactoring was called for, introducing
> some pure abstract base classes with reduced functionality, or sometimes
> just eliminating dependencies altogether.
> My planned next step is to move the following APIs over, with
> proposed package names (all under org.apache.myfaces.trinidad,
> of course)
>  * render.RenderingContext
>  * render.PartialPageContext
>  * render.LocaleContext
>  * render.FormData
>  * skin.Skin
>  * skin.Icon
> Option 2 I can think of is to use context.RenderingContext instead
> of render.RenderingContext (and likewise for all the first four).
> After that, the only classes I'm itching to make public are CoreRenderer
> and RenderUtils, both of which would go into o.a.m.t.render.  After
> that, I can think of a bunch of candidates, like some of the output
> utility functions in core.xhtml, maybe RenderKitDecorator, etc.,
> but we can take those on more slowly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ADFFACES-198) Making renderer APIs public

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-198?page=comments#action_12437964 ] 
            
Adam Winer commented on ADFFACES-198:
-------------------------------------

Used context.RenderingContext, etc.

Other than the 6 classes listed above, SkinFactory was moved into the public API.  No other classes have been moved at this time, but others are certainly candidates.

> Making renderer APIs public
> ---------------------------
>
>                 Key: ADFFACES-198
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-198
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Matthias Weßendorf
>         Assigned To: Adam Winer
>            Priority: Minor
>
> quote from Adam Winer of the dev list:
> The goal is to move APIs out of trinidad-impl and into trinidad-api, but
> a number of the desired APIs pulled in a lot of code that really shouldn't
> be made public.  So, a bunch of refactoring was called for, introducing
> some pure abstract base classes with reduced functionality, or sometimes
> just eliminating dependencies altogether.
> My planned next step is to move the following APIs over, with
> proposed package names (all under org.apache.myfaces.trinidad,
> of course)
>  * render.RenderingContext
>  * render.PartialPageContext
>  * render.LocaleContext
>  * render.FormData
>  * skin.Skin
>  * skin.Icon
> Option 2 I can think of is to use context.RenderingContext instead
> of render.RenderingContext (and likewise for all the first four).
> After that, the only classes I'm itching to make public are CoreRenderer
> and RenderUtils, both of which would go into o.a.m.t.render.  After
> that, I can think of a bunch of candidates, like some of the output
> utility functions in core.xhtml, maybe RenderKitDecorator, etc.,
> but we can take those on more slowly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Resolved: (ADFFACES-198) Making renderer APIs public

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-198?page=all ]

Adam Winer resolved ADFFACES-198.
---------------------------------

    Resolution: Fixed

> Making renderer APIs public
> ---------------------------
>
>                 Key: ADFFACES-198
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-198
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Matthias Weßendorf
>         Assigned To: Adam Winer
>            Priority: Minor
>
> quote from Adam Winer of the dev list:
> The goal is to move APIs out of trinidad-impl and into trinidad-api, but
> a number of the desired APIs pulled in a lot of code that really shouldn't
> be made public.  So, a bunch of refactoring was called for, introducing
> some pure abstract base classes with reduced functionality, or sometimes
> just eliminating dependencies altogether.
> My planned next step is to move the following APIs over, with
> proposed package names (all under org.apache.myfaces.trinidad,
> of course)
>  * render.RenderingContext
>  * render.PartialPageContext
>  * render.LocaleContext
>  * render.FormData
>  * skin.Skin
>  * skin.Icon
> Option 2 I can think of is to use context.RenderingContext instead
> of render.RenderingContext (and likewise for all the first four).
> After that, the only classes I'm itching to make public are CoreRenderer
> and RenderUtils, both of which would go into o.a.m.t.render.  After
> that, I can think of a bunch of candidates, like some of the output
> utility functions in core.xhtml, maybe RenderKitDecorator, etc.,
> but we can take those on more slowly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira