You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ja...@apache.org on 2015/02/10 18:50:54 UTC

phoenix git commit: PHOENIX-1649 Remove System.out/System.err debugging messages (Rajeshbabu)

Repository: phoenix
Updated Branches:
  refs/heads/master acb87990d -> 7dc3d8421


PHOENIX-1649 Remove System.out/System.err debugging messages (Rajeshbabu)


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/7dc3d842
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/7dc3d842
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/7dc3d842

Branch: refs/heads/master
Commit: 7dc3d84218bdcc9a9d408283f3badab9230b1ad9
Parents: acb8799
Author: James Taylor <jt...@salesforce.com>
Authored: Tue Feb 10 09:50:42 2015 -0800
Committer: James Taylor <jt...@salesforce.com>
Committed: Tue Feb 10 09:50:42 2015 -0800

----------------------------------------------------------------------
 .../wal/WALReplayWithIndexWritesAndCompressedWALIT.java           | 2 +-
 .../src/main/java/org/apache/phoenix/schema/MetaDataClient.java   | 3 ---
 .../test/java/org/apache/phoenix/schema/types/PDataTypeTest.java  | 1 -
 .../src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java  | 3 +--
 4 files changed, 2 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/7dc3d842/phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java b/phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
index b3a980e..8cf8a8a 100644
--- a/phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
+++ b/phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
@@ -293,7 +293,7 @@ private int getKeyValueCount(HTable table) throws IOException {
     int count = 0;
     for (Result res : results) {
       count += res.list().size();
-      System.out.println(count + ") " + res);
+      LOG.debug(count + ") " + res);
     }
     results.close();
 

http://git-wip-us.apache.org/repos/asf/phoenix/blob/7dc3d842/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java b/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
index 2722cb6..61ee081 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
@@ -332,9 +332,6 @@ public class MetaDataClient {
             table = connection.getMetaDataCache().getTable(new PTableKey(tenantId, fullTableName));
             tableTimestamp = table.getTimeStamp();
         } catch (TableNotFoundException e) {
-            System.err.println(e);
-            // TODO: Try again on services cache, as we may be looking for
-            // a global multi-tenant table
         }
         // Don't bother with server call: we can't possibly find a newer table
         if (table != null && !alwaysHitServer && (systemTable || tableTimestamp == clientTimeStamp - 1)) {

http://git-wip-us.apache.org/repos/asf/phoenix/blob/7dc3d842/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java b/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java
index 90730bc..b2e6e0b 100644
--- a/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java
+++ b/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java
@@ -1011,7 +1011,6 @@ public class PDataTypeTest {
                 byte[] bytes = Bytes.toBytesBinary(str);
                 Object o = PDecimal.INSTANCE.toObject(bytes);
                 assertNotNull(o);
-                //System.out.println(o.getClass() +" " + bytesToHex(bytes)+" " + o+" ");
             }
         }
     }

http://git-wip-us.apache.org/repos/asf/phoenix/blob/7dc3d842/phoenix-pig/src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java
----------------------------------------------------------------------
diff --git a/phoenix-pig/src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java b/phoenix-pig/src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java
index 51b2478..594abe6 100644
--- a/phoenix-pig/src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java
+++ b/phoenix-pig/src/it/java/org/apache/phoenix/pig/PhoenixHBaseLoaderIT.java
@@ -520,8 +520,7 @@ public class PhoenixHBaseLoaderIT {
         Iterator<Tuple> iterator = pigServer.openIterator("A");
         int recordsRead = 0;
         while (iterator.hasNext()) {
-            Tuple tuple = iterator.next();
-            System.out.println(" the field value is "+tuple.get(1));
+            iterator.next();
             recordsRead++;
         }
         assertEquals(rows/2, recordsRead);