You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:51:34 UTC

[GitHub] [skywalking] wankai123 commented on a change in pull request #7632: Support nacos grouped dynamic configurations.

wankai123 commented on a change in pull request #7632:
URL: https://github.com/apache/skywalking/pull/7632#discussion_r700059866



##########
File path: oap-server/server-configuration/configuration-nacos/src/main/java/org/apache/skywalking/oap/server/configuration/nacos/NacosConfigWatcherRegister.java
##########
@@ -92,8 +91,35 @@ public NacosConfigWatcherRegister(NacosServerSettings settings) throws NacosExce
 
     @Override
     public Optional<GroupConfigTable> readGroupConfig(final Set<String> keys) {
-        // TODO: implement readGroupConfig
-        return Optional.empty();
+        Set<String> keys1 = new HashSet<>();
+        keys1.add("test-module.default.testKeyGroup");

Review comment:
       sorry, forgot to remove it...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org