[jira] Updated: (ADFFACES-1) tableSelectMany may break with non-string row keys

["Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/ADFFACES-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-1:
--------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
>                 Key: ADFFACES-1
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-1
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>    Affects Versions: 1.0.0-incubating-core
>         Environment: all
>            Reporter: Frank Felix Debatin
>         Assigned To: Adam Winer
>             Fix For: 1.0.0-incubating-core
>
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
>  private Object _next()
>       {
>         while(rowKeyIterator.hasNext())
>         {
>           String rowKey = (String) rowKeyIterator.next(); // !? 
>           if (!set.contains(rowKey))
>             return rowKey;
>         }
>         return null;
>       }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.