Re: bugs in AbstractStore / some questions regarding slide stores

[Remy Maucherat <re...@apache.org>]

> Hi!
>
> There are some bugs in your AbstractStore.
> Please apply this patch:
>
>
> diff -w -i -r1.1 AbstractStore.java
> 1014c1014
> <             enlist(revisionDescriptorsStore);
> ---
> >             enlist(revisionDescriptorStore);
> 1444c1444
> <             throw new ServiceAccessException(this, e.getMessage());
> ---
> >             throw new ServiceAccessException(this, e);

Good find, I've applied the patch.

> I have still some questions, because nobody answered yet.
> (or did they answer to the list, only?)
>
> - You wrote, indexing is not implemented yet. Does that mean,
> IndexStore is not implemented, or are the calls to it implemented
> neither? I do not get any calls to the IndexStore-methods.

Some of the DASL code is there, but it's a work in progress.
See the message ported by Martin about that on slide-dev earlier today.

> - What is the semantic of SecurityStore.enumeratePermissions()?
> Should it return all permissions where
> * subjecturi == uri
> * uri contained in subjecturi (child folders)
> * subjecturi contained in uri (parent folders)

It's the first one.

> - Why doesn't Slide call the XA interface of the stores, ie commit,
> rollback ...?
> Is it intended to be called by someone else? Is it not implemented,
> yet? Do I have to set some parameters for activating XA?

I'm not sure I understand this, as it does (see SlideTransaction.commit, for
example).

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>