You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2014/11/13 01:35:54 UTC
Review Request 27945: Add c++11 initializer_list check to configure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Repository: mesos-git
Description
-------
Check both that initializer_list exists, and that a standard container (vector) accepts it.
Diffs
-----
m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
Diff: https://reviews.apache.org/r/27945/diff/
Testing
-------
make distcheck with GCC on ubuntu 14.04
Thanks,
Cody Maloney
Re: Review Request 27945: Add c++11 initializer_list check to
configure
Posted by Cody Maloney <co...@mesosphere.io>.
> On Nov. 13, 2014, 12:38 a.m., Dominic Hamon wrote:
> > m4/ax_cxx_compile_stdcxx_11.m4, line 111
> > <https://reviews.apache.org/r/27945/diff/1/?file=760765#file760765line111>
> >
> > do you also want to check that std::initializer_list can be used as a type in a constructor for a user-defined class?
> >
> > for completeness.
Adding
> On Nov. 13, 2014, 12:38 a.m., Dominic Hamon wrote:
> > m4/ax_cxx_compile_stdcxx_11.m4, line 112
> > <https://reviews.apache.org/r/27945/diff/1/?file=760765#file760765line112>
> >
> > we can avoid string header by using ints.
> >
> > it also shouldn't need to be static.
I want to make sure the const char * -> std::string stuff works (especially since It's one of the things I use most commonly with initializer_list, and is relatively easy for a C++ compiler to get wrong.
Dropping the static
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/#review61152
-----------------------------------------------------------
On Nov. 13, 2014, 12:35 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27945/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:35 a.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check both that initializer_list exists, and that a standard container (vector) accepts it.
>
>
> Diffs
> -----
>
> m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
>
> Diff: https://reviews.apache.org/r/27945/diff/
>
>
> Testing
> -------
>
> make distcheck with GCC on ubuntu 14.04
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 27945: Add c++11 initializer_list check to
configure
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/#review61152
-----------------------------------------------------------
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102646>
do you also want to check that std::initializer_list can be used as a type in a constructor for a user-defined class?
for completeness.
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102644>
we can avoid string header by using ints.
it also shouldn't need to be static.
- Dominic Hamon
On Nov. 12, 2014, 4:35 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27945/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 4:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check both that initializer_list exists, and that a standard container (vector) accepts it.
>
>
> Diffs
> -----
>
> m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
>
> Diff: https://reviews.apache.org/r/27945/diff/
>
>
> Testing
> -------
>
> make distcheck with GCC on ubuntu 14.04
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 27945: Add c++11 initializer_list check to
configure
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/#review61290
-----------------------------------------------------------
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102836>
comments should start with a capital letter.
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102832>
kill the newline
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102834>
explicit?
i'm torn about explicit with InitializerList so I'll defer to you.
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102835>
kill the newlines.
- Dominic Hamon
On Nov. 12, 2014, 5:02 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27945/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 5:02 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check both that initializer_list exists, and that a standard container (vector) accepts it.
>
>
> Diffs
> -----
>
> m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
>
> Diff: https://reviews.apache.org/r/27945/diff/
>
>
> Testing
> -------
>
> make distcheck with GCC on ubuntu 14.04
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 27945: Add c++11 initializer_list check to
configure
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/#review61291
-----------------------------------------------------------
Ship it!
Thanks Cody!
Please end the review summaries with periods, as they get directly translated into commit messages, I updated the message:
"Added c++11 initializer_list check to configure."
We've tried to use past tense but present tense has been slipping through a lot as of late. ;)
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102833>
Let's match the brace-on-a-newline style here :)
I'll do this for you.
m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27945/#comment102837>
Let's remove the extra whitespace introduced here, I'll do this for you.
- Ben Mahler
On Nov. 13, 2014, 1:02 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27945/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:02 a.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check both that initializer_list exists, and that a standard container (vector) accepts it.
>
>
> Diffs
> -----
>
> m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
>
> Diff: https://reviews.apache.org/r/27945/diff/
>
>
> Testing
> -------
>
> make distcheck with GCC on ubuntu 14.04
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 27945: Add c++11 initializer_list check to
configure
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 1:02 a.m.)
Review request for mesos, Ben Mahler and Dominic Hamon.
Changes
-------
Test that initializer_list works for a user provided class.
Repository: mesos-git
Description
-------
Check both that initializer_list exists, and that a standard container (vector) accepts it.
Diffs (updated)
-----
m4/ax_cxx_compile_stdcxx_11.m4 d166aa1adf56888ae8f6025469e35165e1f21d61
Diff: https://reviews.apache.org/r/27945/diff/
Testing
-------
make distcheck with GCC on ubuntu 14.04
Thanks,
Cody Maloney