You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "VuMartin (via GitHub)" <gi...@apache.org> on 2026/08/06 01:39:35 UTC
[PR] fix(agent-service): remove dangling links when input ports shrink [texera]
VuMartin opened a new pull request, #7349:
URL: https://github.com/apache/texera/pull/7349
### What changes were proposed in this PR?
This PR fixes a bug in `WorkflowState.updateOperatorInputPorts` where shrinking an operator's input port count left links targeting removed input ports. The method now removes any links whose target port no longer exists by calling `deleteLink`, preventing dangling links from remaining in the workflow state.
A regression test was also added to verify that links targeting deleted input ports are removed when the input port count is reduced.
### Any related issues, documentation, discussions?
Closes #7169
### How was this PR tested?
Added a regression test covering the case where an operator's input ports are reduced while a link targets one of the removed ports.
Verified with:
```bash
bun test --test-name-pattern="removes links targeting input ports that are dropped"
bun test
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT (5.5 mini)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): delete links targeting removed input ports when shrinking input ports [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7349:
URL: https://github.com/apache/texera/pull/7349#issuecomment-5286668125
Backport PR opened: draft #7637 (https://github.com/apache/texera/pull/7637) to `release/v1.2`, assigned to @VuMartin — needs manual work because the cherry-pick conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): remove dangling links when input ports shrink [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7349:
URL: https://github.com/apache/texera/pull/7349#issuecomment-5199421848
### :warning: JUnit XML file not found
The CLI was unable to find any JUnit XML files to upload.
For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): remove dangling links when input ports shrink [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7349:
URL: https://github.com/apache/texera/pull/7349#issuecomment-5199417564
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/31063369554)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): remove dangling links when input ports shrink [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #7349:
URL: https://github.com/apache/texera/pull/7349#issuecomment-5212843410
@VuMartin Add screenshots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): remove dangling links when input ports shrink [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7349:
URL: https://github.com/apache/texera/pull/7349#issuecomment-5199417226
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`, `@bobbai00`
You can notify them by mentioning `@mengw15`, `@bobbai00` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-service): delete links targeting removed input ports when shrinking input ports [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #7349:
URL: https://github.com/apache/texera/pull/7349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org