You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Y. SREENIVASULU REDDY (JIRA)" <ji...@apache.org> on 2012/11/05 09:35:12 UTC
[jira] [Created] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Y. SREENIVASULU REDDY created HBASE-7097:
--------------------------------------------
Summary: Log message in SecureServer.class pointing to wrong class path.
Key: HBASE-7097
URL: https://issues.apache.org/jira/browse/HBASE-7097
Project: HBase
Issue Type: Improvement
Components: security
Affects Versions: 0.94.2, 0.92.2
Reporter: Y. SREENIVASULU REDDY
Priority: Minor
Fix For: 0.92.3, 0.94.3
log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
{code}
public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
private static final Log AUDITLOG =
LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490714#comment-13490714 ]
Andrew Purtell commented on HBASE-7097:
---------------------------------------
+1, looks like a remnant of the port from Hadoop that wasn't caught on code review.
> Log message in SecureServer.class pointing to wrong class path.
> ---------------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-7097.
-----------------------------------
Resolution: Fixed
Committed addendum to 0.94 and 0.92 branches.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490782#comment-13490782 ]
Lars Hofhansl commented on HBASE-7097:
--------------------------------------
+1
> Log message in SecureServer.class pointing to wrong class path.
> ---------------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491865#comment-13491865 ]
Lars Hofhansl commented on HBASE-7097:
--------------------------------------
I think this looks reasonable.
Should we leave the "SecurityEnabled" message?
I have no good sense about how frequently
{code}
if (LOG.isDebugEnabled())
LOG.debug("Created SASL server with mechanism = "
+ authMethod.getMechanismName());
{code}
or
{code}
if (LOG.isDebugEnabled())
LOG.debug("Kerberos principal name is " + fullName);
{code}
Would called, but I think it should be OK to leave those at DEBUG.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490888#comment-13490888 ]
Hudson commented on HBASE-7097:
-------------------------------
Integrated in HBase-0.94 #574 (See [https://builds.apache.org/job/HBase-0.94/574/])
HBASE-7097. Log message in SecureServer.class uses wrong class name (Y. Sreenivasulu Reddy) (Revision 1405906)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492033#comment-13492033 ]
Andrew Purtell commented on HBASE-7097:
---------------------------------------
Thanks for taking a look Lars. I'll commit the proposed addendum with the additional log messages you called out moved to TRACE level shortly unless there is further comment. I don't think they are that useful.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492130#comment-13492130 ]
Hudson commented on HBASE-7097:
-------------------------------
Integrated in HBase-0.92 #605 (See [https://builds.apache.org/job/HBase-0.92/605/])
Amend HBASE-7097. Change per-request logging in SecureServer to TRACE level (Revision 1406421)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7097:
----------------------------------
Attachment: HBASE-7097-addendum.patch
Proposed addendum attached. Any more of the DEBUG level messages should go to TRACE?
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7097:
----------------------------------
Attachment: HBASE-7097-addendum.patch
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490964#comment-13490964 ]
Hudson commented on HBASE-7097:
-------------------------------
Integrated in HBase-0.92 #604 (See [https://builds.apache.org/job/HBase-0.92/604/])
HBASE-7097. Log message in SecureServer.class uses wrong class name (Y. Sreenivasulu Reddy) (Revision 1405909)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491028#comment-13491028 ]
Andrew Purtell commented on HBASE-7097:
---------------------------------------
bq. But if we actually fix the logger to use the correct class name, we should also change per-request logging to only happen at trace level instead of debug, so that existing HBase setups with debug level enabled for the org.apache.hadoop.hbase parent don't start getting noisy per-request messages.
+1 here, can do an addendum
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492038#comment-13492038 ]
Lars Hofhansl commented on HBASE-7097:
--------------------------------------
+1
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491204#comment-13491204 ]
Lars Hofhansl commented on HBASE-7097:
--------------------------------------
I'm also fine with reverting and just adding a comment. This class is gone in 0.96, so when 0.94 is eventually phased out this is no longer a problem anyway.
Either way, make an addendum Andy?
+1 on changing all debug logs using this logger to trace,
alternatively
+1 on reverting with comment
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492094#comment-13492094 ]
Hudson commented on HBASE-7097:
-------------------------------
Integrated in HBase-0.94 #575 (See [https://builds.apache.org/job/HBase-0.94/575/])
Amend HBASE-7097. Change per-request logging in SecureServer to TRACE level (Revision 1406420)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491053#comment-13491053 ]
Andrew Purtell commented on HBASE-7097:
---------------------------------------
bq. Maybe we should roll this back, at least for 0.94?
And we will do it again in 6 months when it gets pointed out again and this detail has slipped cache again of the first wanderers by? Better to finish with the proposed addendum I think.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Posted by "Y. SREENIVASULU REDDY (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Y. SREENIVASULU REDDY updated HBASE-7097:
-----------------------------------------
Status: Patch Available (was: Open)
> Log message in SecureServer.class pointing to wrong class path.
> ---------------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.94.2, 0.92.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491064#comment-13491064 ]
Andrew Purtell commented on HBASE-7097:
---------------------------------------
bq. Sure... We can change the per request logging to TRACE too.
I'll wait for a bit to see if there's more opinion, otherwise will do so.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-7097) Log message in
SecureServer.class uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491053#comment-13491053 ]
Andrew Purtell edited comment on HBASE-7097 at 11/5/12 11:59 PM:
-----------------------------------------------------------------
bq. Maybe we should roll this back, at least for 0.94?
And we will do it again in 6 months when it gets pointed out again and this detail has slipped cache again of the first wanderers by? Better to finish with the proposed addendum I think.
Edit: Either way we need an addendum, if rolling back we need a comment added as explanation.
was (Author: apurtell):
bq. Maybe we should roll this back, at least for 0.94?
And we will do it again in 6 months when it gets pointed out again and this detail has slipped cache again of the first wanderers by? Better to finish with the proposed addendum I think.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496083#comment-13496083 ]
Hudson commented on HBASE-7097:
-------------------------------
Integrated in HBase-0.94-security #83 (See [https://builds.apache.org/job/HBase-0.94-security/83/])
Amend HBASE-7097. Change per-request logging in SecureServer to TRACE level (Revision 1406420)
HBASE-7097. Log message in SecureServer.class uses wrong class name (Y. Sreenivasulu Reddy) (Revision 1405906)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
apurtell :
Files :
* /hbase/branches/0.94/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch, HBASE-7097-addendum.patch, HBASE-7097-addendum.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-7097.
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed to 0.94 and 0.92 branches. Thanks for the patch. Thanks for the ack on 0.94 Lars.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-7097:
----------------------------------
Summary: Log message in SecureServer.class uses wrong class name (was: Log message in SecureServer.class pointing to wrong class path.)
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491051#comment-13491051 ]
Lars Hofhansl commented on HBASE-7097:
--------------------------------------
Maybe we should roll this back, at least for 0.94?
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reopened HBASE-7097:
----------------------------------
Sure... We can change the per request logging to TRACE too.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Posted by "Y. SREENIVASULU REDDY (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Y. SREENIVASULU REDDY updated HBASE-7097:
-----------------------------------------
Status: Open (was: Patch Available)
> Log message in SecureServer.class pointing to wrong class path.
> ---------------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.94.2, 0.92.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7097) Log message in SecureServer.class
pointing to wrong class path.
Posted by "Y. SREENIVASULU REDDY (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Y. SREENIVASULU REDDY updated HBASE-7097:
-----------------------------------------
Attachment: HBASE-7097_94.patch
attached patch for 94 branch.
> Log message in SecureServer.class pointing to wrong class path.
> ---------------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491079#comment-13491079 ]
Gary Helmling commented on HBASE-7097:
--------------------------------------
+1 to an addendum to change the per-request logging to trace level. Works for me.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7097) Log message in SecureServer.class
uses wrong class name
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490975#comment-13490975 ]
Gary Helmling commented on HBASE-7097:
--------------------------------------
This was unfortunately intentional, at least in the {{LOG}} instance, in order to provide an admittedly cludgey way to enable debug logging for the entire org.apache.hadoop.hbase logger without spamming region server logs with per-request messages -- per request metrics only get logged if you enable debug logging for org.apache.hadoop.ipc. It preserves the same technique that is used in HBaseServer.
No argument from me that the technique is ugly. But if we actually fix the logger to use the correct class name, we should also change per-request logging to only happen at trace level instead of debug, so that existing HBase setups with debug level enabled for the org.apache.hadoop.hbase parent don't start getting noisy per-request messages.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>
> Key: HBASE-7097
> URL: https://issues.apache.org/jira/browse/HBASE-7097
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.92.2, 0.94.2
> Reporter: Y. SREENIVASULU REDDY
> Priority: Minor
> Fix For: 0.92.3, 0.94.3
>
> Attachments: HBASE-7097_94.patch
>
>
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");
> private static final Log AUDITLOG =
> LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira