[jira] [Commented] (ORC-218) [C++] Cache timezone information in the library.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113015#comment-16113015 ] 

ASF GitHub Bot commented on ORC-218:
------------------------------------

Github user grundprinzip commented on a diff in the pull request:

    https://github.com/apache/orc/pull/142#discussion_r131188310
  
    --- Diff: c++/src/CMakeLists.txt ---
    @@ -125,6 +125,83 @@ include_directories (
       ${LZ4_INCLUDE_DIRS}
       )
     
    +# To avoid reading the Timezone database from disk, we load the file during the
    +# build and inject them as binary into the library. This can increase the size
    +# of library but avoids doing system calls at runtime. The behavior can be
    +# disabled by using the CMake flag NO_EMBEDDED_TZ_DB
    +if (NOT DEFINED EMBEDDED_TZ_DB)
    +  set(EMBEDDED_TZ_DB ON)
    --- End diff --
    
    Done


> [C++] Cache timezone information in the library.
> ------------------------------------------------
>
>                 Key: ORC-218
>                 URL: https://issues.apache.org/jira/browse/ORC-218
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Martin Grund
>
> Right now, for every lookup of a timezone, the library will go to disk and parse the timezone file. While the results are cached, doing these system calls should be avoided in environments with restricted system calls.
> I prepared a patch that will at build time load all the time zone files into the binary and instead of accessing disk for the TZ information will simply load the buffer from memory. In addition this allows the user to compile the library with a static timezone to be assumed for local use. This comes in handy to avoid yet another set of system calls to assume the local timezone.
> The feature can be controlled using the following CMake flags
> * NO_EMBEDED_TZ_DB - to turn it off, by default is on
> * STATIC_TZ=VAL - where val is a name of a timezone.
> I'll create a PR for code-review.
> Would be great if you could consider this patch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)