You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/12 12:48:30 UTC
[GitHub] [flink] reswqa opened a new pull request, #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
reswqa opened a new pull request, #22383:
URL: https://github.com/apache/flink/pull/22383
## What is the purpose of the change
*Docs for externalized connectors should point to the branch where that version of the connector doc are published, otherwise documentation fixes are not visible until a new release is made. After this, we can safely delete all dedicated doc branches.*
## Brief change log
- *Track stable branch of externalized connector instead of specific release tag.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506541195
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506537213
Thanks for the clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506504043
@reswqa I performed these releases so will fix the missing branches. For AWS connectors I would rather not promote `main` to `5.0-SNAPSHOT` since this means we need to create PRs against both `v4.x` and `main`. This creates additional work on the developers and maintainers. But agree there should be a v4.1 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506524601
@dannycranmer Thank you for your willingness to help fix the branch missing problem.
> For AWS connectors I would rather not promote main to 5.0-SNAPSHOT until we have breaking changes that require a 5.x, otherwise we need to create PRs against both v4.x and main.
I'm a little curious, why do we still have `non-bugfix` changes that need to be picked to the `v4.0` branch even though `v4.0.0` version has been released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #22383:
URL: https://github.com/apache/flink/pull/22383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1505219372
@dannycranmer You might be interested in this update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1509889401
Thanks @reswqa, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506542390
Ok, branches should be good. I have left the `-docs` branches there for now since open PRs might reference them. I will clean up later. Sorry for the inconvenience, I will update the release process incase it is wrong, or follow it better next time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506564407
Never mind, thanks for fixing it so quickly 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506566119
Looks like CI is happy now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1508119028
@dannycranmer Would you taking a look at this changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506532564
Minor (4.x) versions are not just for bug fixes, they are for non-breaking changes. A jump from 4.x to 5.x indicates a breaking change which we try to avoid. So ideally we stay on the 4.x path for longer. Right now we have released 4.0 and 4.1 and are working on 4.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1506461557
It seems that:
- `flink-connector-mongodb` has been released `v1.0.0` already but does not have the `v1.0` branch and the `main` branch artifact version is still `1.0-SNAPSHOT`. IIUC, after `v1.0.0` released, it should be updated to `2.0-SNAPSHOT`?
- `flink-connector-aws` has been released `v4.1.0` already but does not have the `v4.1` branch. In [Branch model](https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development), we can find the following description: `branches are called v<major>.<minor>, for example v3.2`. If I understand correctly, we should have a `v4.1` branch. Or is it up to the connector owner to decide whether to create such a branch?
@MartijnVisser Sorry to bother you, but I really want to hear your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22383: [FLINK-31779][docs] Track stable branch of externalized connector instead of specific release tag
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22383:
URL: https://github.com/apache/flink/pull/22383#issuecomment-1505230935
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b81fc0f9b38b418d93295689140b4ffcd50ea1d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b81fc0f9b38b418d93295689140b4ffcd50ea1d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b81fc0f9b38b418d93295689140b4ffcd50ea1d7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org