You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2022/07/09 10:00:15 UTC

[GitHub] [tez] abstractdog opened a new pull request, #230: TEZ-3322: Add Apache license to the generated tez-configuration-template files

abstractdog opened a new pull request, #230:
URL: https://github.com/apache/tez/pull/230

   tested:
   built tez-javadoc-tools procject
   ```
   cd tez-runtime-library
   mvn site
   ```
   checked ./target/site/apidocs/configs/tez-runtime-default-template.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tez] abstractdog commented on pull request #230: TEZ-3322: Add Apache license to the generated tez-configuration-template files

Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #230:
URL: https://github.com/apache/tez/pull/230#issuecomment-1598157187

   thanks @ayushtkn  for the review!
   can you take a look at this @rbalamohan , @sidseth  please? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tez] tez-yetus commented on pull request #230: TEZ-3322: Add Apache license to the generated tez-configuration-template files

Posted by GitBox <gi...@apache.org>.
tez-yetus commented on PR #230:
URL: https://github.com/apache/tez/pull/230#issuecomment-1179521182

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  13m  4s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 48s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 44s |  master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  compile  |   0m 44s |  master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m 17s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   1m 16s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   1m 15s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 14s |  the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javac  |   0m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 14s |  the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   0m 14s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m  9s |  tez-tools/tez-javadoc-tools: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | -1 :x: |  xml  |   0m  1s |  The patch has 1 ill-formed XML file(s).  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  findbugs  |   0m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 14s |  tez-javadoc-tools in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 18s |  The patch does not generate ASF License warnings.  |
   |  |   |  37m 47s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | XML | Parsing Error(s): |
   |   | tez-tools/tez-javadoc-tools/src/main/resources/apache-header.xml |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/230 |
   | JIRA Issue | TEZ-3322 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml |
   | uname | Linux b1b261e7275d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / a192ec444 |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/1/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt |
   | xml | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/1/artifact/out/xml.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/1/testReport/ |
   | Max. process+thread count | 96 (vs. ulimit of 5500) |
   | modules | C: tez-tools/tez-javadoc-tools U: tez-tools/tez-javadoc-tools |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/1/console |
   | versions | git=2.25.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tez] tez-yetus commented on pull request #230: TEZ-3322: Add Apache license to the generated tez-configuration-template files

Posted by GitBox <gi...@apache.org>.
tez-yetus commented on PR #230:
URL: https://github.com/apache/tez/pull/230#issuecomment-1179663259

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  15m 48s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 44s |  master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  compile  |   0m 43s |  master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   1m 17s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   1m 15s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 15s |  the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javac  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 13s |  the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   0m 13s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 10s |  tez-tools/tez-javadoc-tools: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  findbugs  |   0m 29s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 14s |  tez-javadoc-tools in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 17s |  The patch does not generate ASF License warnings.  |
   |  |   |  25m 13s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/tez/pull/230 |
   | JIRA Issue | TEZ-3322 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
   | uname | Linux 0ac630e8179a 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/tez.sh |
   | git revision | master / a192ec444 |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/testReport/ |
   | Max. process+thread count | 95 (vs. ulimit of 5500) |
   | modules | C: tez-tools/tez-javadoc-tools U: tez-tools/tez-javadoc-tools |
   | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/console |
   | versions | git=2.25.1 maven=3.6.3 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tez] abstractdog commented on pull request #230: TEZ-3322: Add Apache license to the generated tez-configuration-template files

Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #230:
URL: https://github.com/apache/tez/pull/230#issuecomment-1179516424

   I just picked this up while creating tez 0.10.2, can you please review @sidseth ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org