You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2007/12/05 08:54:43 UTC
[jira] Created: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
----------------------------------------------------------------------------------------------------------------------
Key: HADOOP-2352
URL: https://issues.apache.org/jira/browse/HADOOP-2352
Project: Hadoop
Issue Type: Bug
Components: native
Affects Versions: 0.15.1
Reporter: Arun C Murthy
Assignee: Arun C Murthy
Fix For: 0.15.2
We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2352:
----------------------------------
Attachment: HADOOP-2352_1_20071218.patch
Here is a straight-forward patch ...
The meat of the patch is:
{noformat}
Index: src/native/configure.ac
===================================================================
--- src/native/configure.ac (revision 605197)
+++ src/native/configure.ac (working copy)
@@ -61,12 +61,6 @@
LDFLAGS=$ldflags_bak
AC_SUBST([JNI_LDFLAGS])
-dnl Check for '-lz'
-AC_CHECK_LIB([z], [deflate])
-
-dnl Check for '-llzo2'
-AC_CHECK_LIB([lzo2], [lzo_init])
-
# Checks for header files.
dnl Check for Ansi C headers
AC_HEADER_STDC
{noformat}
----
bq. Is this required for 0.15.2?
This is a long-standing bug, I believe it should go in asap...
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.15.2
>
> Attachments: HADOOP-2352_1_20071218.patch
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2352:
----------------------------------
Status: Patch Available (was: Open)
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.15.2
>
> Attachments: HADOOP-2352_1_20071218.patch
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2352:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.16.0
>
> Attachments: HADOOP-2352_1_20071218.patch
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552778 ]
Hadoop QA commented on HADOOP-2352:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371857/HADOOP-2352_1_20071218.patch
against trunk revision r605102.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1381/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1381/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1381/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1381/console
This message is automatically generated.
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.15.2
>
> Attachments: HADOOP-2352_1_20071218.patch
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-2352:
----------------------------------
Fix Version/s: (was: 0.15.2)
0.16.0
On second thoughts, I'm marking this for 0.16.0 - this isn't a regression and won't really hurt...
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.16.0
>
> Attachments: HADOOP-2352_1_20071218.patch
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2352) Remove AC_LIB_CHECK from
src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on
libz.so/liblzo.so
Posted by "Sameer Paranjpye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551232 ]
Sameer Paranjpye commented on HADOOP-2352:
------------------------------------------
Is this required for 0.15.2?
> Remove AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2352
> URL: https://issues.apache.org/jira/browse/HADOOP-2352
> Project: Hadoop
> Issue Type: Bug
> Components: native
> Affects Versions: 0.15.1
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.15.2
>
>
> We should AC_LIB_CHECK from src/native/configure.ac to ensure libhadoop.so doesn't have a dependency on libz.so/liblzo.so, the check for libz/liblzo headers via AC_HEADERS_CHECK is a stronger guarantee anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.