You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/11/03 19:55:54 UTC
[kudu-CR] installation.adoc: add flex dependency
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8463
to review the following change.
Change subject: installation.adoc: add flex dependency
......................................................................
installation.adoc: add flex dependency
Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
---
M docs/installation.adoc
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8463/1
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed a vote on this change.
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 06 Nov 2017 22:20:05 +0000
Gerrit-HasComments: No
[kudu-CR] installation.adoc: add flex dependency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add flex dependency
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc@536
PS1, Line 536: $ brew install autoconf automake cmake git krb5 libtool openssl pkg-config pstree
Is flex needed on macOS as well?
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc@622
PS1, Line 622: git clone https://github.com/apache/kudu
Here too (if macOS).
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc@649
PS1, Line 649: - JDK 7 or JDK 8
Would also be worth bubbling this up since now JDK 7 or 8 is a requirement for building all of Kudu.
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 03 Nov 2017 20:50:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc@536
PS1, Line 536: $ brew install autoconf automake cmake git krb5 libtool openssl pkg-config pstree
> Is flex needed on macOS as well?
Flex ships with macos.
http://gerrit.cloudera.org:8080/#/c/8463/1/docs/installation.adoc@649
PS1, Line 649: - JDK 7 or JDK 8
> Would also be worth bubbling this up since now JDK 7 or 8 is a requirement
Done
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 06 Nov 2017 16:56:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
Patch Set 2: Verified+1
flake
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 06 Nov 2017 20:18:41 +0000
Gerrit-HasComments: No
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
installation.adoc: add JDK and flex dependencies
Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Reviewed-on: http://gerrit.cloudera.org:8080/8463
Tested-by: Dan Burkert <da...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M docs/installation.adoc
1 file changed, 12 insertions(+), 8 deletions(-)
Approvals:
Dan Burkert: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] installation.adoc: add JDK and flex dependencies
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8463
to look at the new patch set (#2).
Change subject: installation.adoc: add JDK and flex dependencies
......................................................................
installation.adoc: add JDK and flex dependencies
Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
---
M docs/installation.adoc
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8463/2
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] installation.adoc: add flex dependency
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 )
Change subject: installation.adoc: add flex dependency
......................................................................
Patch Set 1:
Maybe add to the preflight.py script in thirdparty as well?
--
To view, visit http://gerrit.cloudera.org:8080/8463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1d3c7a033da80becf3b96e3cb00854542bed624
Gerrit-Change-Number: 8463
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 03 Nov 2017 20:35:05 +0000
Gerrit-HasComments: No