You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Anthony Carlucci (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 22:41:10 UTC
[jira] [Created] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Widget - ModelPermissionEvaluator and Service Annotations
---------------------------------------------------------
Key: RAVE-310
URL: https://issues.apache.org/jira/browse/RAVE-310
Project: Rave
Issue Type: Sub-task
Reporter: Anthony Carlucci
Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138330#comment-13138330 ]
Anthony Carlucci commented on RAVE-310:
---------------------------------------
#1: Good catch Jasha - I'll take a look at it.
#2: Another good though - from a pure JPA perspective if the User entity is deleted, it would propagate all the way through and delete the Widget and all instances of RegionWidgets from people's pages. From a business process perspective, we should decide how we want to handle the situation. Perhaps part of the process of deleting a User requires any "ownerships" to be transferred to another user first?
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Carlucci resolved RAVE-310.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.5-INCUBATING
Resolving this issue and created RAVE-333 to handle the Widget ownership improvement when a User is deleted
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Story
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Carlucci reassigned RAVE-310:
-------------------------------------
Assignee: Anthony Carlucci
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Carlucci resolved RAVE-310.
-----------------------------------
Resolution: Fixed
This is completed
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140218#comment-13140218 ]
Anthony Carlucci commented on RAVE-310:
---------------------------------------
For enterprise installations I think an owner will be a necessity (and different from Author). I can see cases where "Author" is "Department ABC" because it is contributed and maintained by a sub-group of people, but there needs to be one point-of-contact owner who is responsible for that gadget. In a federated development environment there won't necessarily be a single webmaster maintaining all widgets. But again this is my opinion :) Perhaps others should weigh in on this?
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Jesse Ciancetta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140262#comment-13140262 ]
Jesse Ciancetta commented on RAVE-310:
--------------------------------------
I agree with Tony -- I think we do need owners for Widgets so we can support federated development (people writing/registering their own Widgets).
I agree that many of the Widgets will be owned and managed by an administrator, but I think its important to support a model where any user can author and register a widget and have it in the unpublished state until an administrator approves it. And I think the ownership is important so that the user who authored/contributed the Widget can continue to manage the metadata for it (change the title/description/spec URL/...) as needed.
I think if a user registers a common Widget that they don't actually own (like from iGoogle for example) then I think an administrator could take ownership of it going forward.
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Raminderjeet Singh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140289#comment-13140289 ]
Raminderjeet Singh commented on RAVE-310:
-----------------------------------------
Having a owner is +1 for me. I want to add another point that how permission are going to work for these Widgets after administrator approves. Now the owner decide to delete it and remove the widget entry from the database (if we will support remove) then we need to make sure we either notify all the users otherwise user will get 404 error. which can be really bad for enterprise install. So we may need to have some way to determine who are the users for this Widget.
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139974#comment-13139974 ]
Jasha Joachimsthal commented on RAVE-310:
-----------------------------------------
I'm not yet convinced a Widget needs an owner. To prevent duplicates, the widget URL is unique. If there's only 1 owner per widget, only the first person who add the widget can have it on his own page. It's also likely that the webmaster will "own" most of the widgets just because he manages the site, not because his widget should exclusively belong to him.
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Jasha Joachimsthal (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal reopened RAVE-310:
-------------------------------------
- submitting the "add new widget" form leads to an NPE, the widget is not added to the database
- admins cannot manage each other's widgets (upgrade john.doe to admin, go to the admin interface and try to change a widgetstatus, you won't be able to do this)
- if the owner of a widget is deleted, but the widget is published and therefore available to everyone, what happens to the widget?
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (RAVE-310) Widget -
ModelPermissionEvaluator and Service Annotations
Posted by "Jasha Joachimsthal (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138177#comment-13138177 ]
Jasha Joachimsthal edited comment on RAVE-310 at 10/28/11 9:15 AM:
-------------------------------------------------------------------
- admins cannot manage each other's widgets (upgrade john.doe to admin, go to the admin interface and try to change a widgetstatus, you won't be able to do this)
- if the owner of a widget is deleted, but the widget is published and therefore available to everyone, what happens to the widget?
was (Author: jashajoachimsthal):
- submitting the "add new widget" form leads to an NPE, the widget is not added to the database
- admins cannot manage each other's widgets (upgrade john.doe to admin, go to the admin interface and try to change a widgetstatus, you won't be able to do this)
- if the owner of a widget is deleted, but the widget is published and therefore available to everyone, what happens to the widget?
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140291#comment-13140291 ]
Jasha Joachimsthal commented on RAVE-310:
-----------------------------------------
Okay that makes sense. So the owner is more or less an administrative contact.
We should work out what happens to the Widget if the owner is deleted, because we have a circular data model now: User -> Page -> Region -> RegionWidget -> Widget -> User
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Matt Franklin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Franklin updated RAVE-310:
-------------------------------
Issue Type: Story (was: Sub-task)
Parent: (was: RAVE-304)
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Story
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140298#comment-13140298 ]
Jasha Joachimsthal commented on RAVE-310:
-----------------------------------------
@Raminderjeet: we can show a nice message "This widget is no longer available, do you want to remove it from the page?" if the RegionWidget doesn't have a Widget anymore.
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Anthony Carlucci (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138421#comment-13138421 ]
Anthony Carlucci commented on RAVE-310:
---------------------------------------
Fixed the incorrect security annotation on updateWidget so admins can now update widgets they don't own. However, the actual persistence of Widgets is still broken as defined by RAVE-319 (this was broken BEFORE I applied the Widget ModelPermissionSecurity code so it is not related to security).
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-310) Widget - ModelPermissionEvaluator and
Service Annotations
Posted by "Raminderjeet Singh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140429#comment-13140429 ]
Raminderjeet Singh commented on RAVE-310:
-----------------------------------------
That would be good enough of 404 errors.
> Widget - ModelPermissionEvaluator and Service Annotations
> ---------------------------------------------------------
>
> Key: RAVE-310
> URL: https://issues.apache.org/jira/browse/RAVE-310
> Project: Rave
> Issue Type: Sub-task
> Reporter: Anthony Carlucci
> Assignee: Anthony Carlucci
> Fix For: 0.5-INCUBATING
>
>
> Create a ModelPermissionEvaluator and Service Annotations for the Widget class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira