You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/03 11:57:42 UTC

[GitHub] [commons-io] garydgregory commented on a change in pull request #268: IO-747 Make commons-io a proper JPMS module

garydgregory commented on a change in pull request #268:
URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678



##########
File path: pom.xml
##########
@@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more.
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>release</id>
+      <properties>
+        <!-- Enable Moditect for releases. This requires JDK 9+ for the build -->

Review comment:
       That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org