You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2025/02/04 01:02:40 UTC
[PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg File [polaris]
HonahX opened a new pull request, #935:
URL: https://github.com/apache/polaris/pull/935
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
This PR is the first follow-up of https://github.com/apache/polaris/pull/906
Updated the website's reference to `generated/bundled-polaris-catalog-service.yaml` instead of `rest-catalog-open-api.yaml`. This change ensures that Polaris-native APIs and models can be removed from `rest-catalog-open-api.yaml` in the next step, allowing it to align with the released version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #935:
URL: https://github.com/apache/polaris/pull/935#issuecomment-2634674743
Thanks @HonahX for the fix, and @jackye1995 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on PR #935:
URL: https://github.com/apache/polaris/pull/935#issuecomment-2634811569
Hi @flyrain Could you please help me revert this one? It works locally but breaks the published website:
```
polaris-management-service/:1 Refused to load the script 'https://cdn.jsdelivr.net/npm/redoc@latest/bundles/redoc.standalone.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' 'unsafe-eval' https://analytics.apache.org/". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.
```
So both management api and catalog api page fails to be rendered :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg File [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #935:
URL: https://github.com/apache/polaris/pull/935#discussion_r1940363102
##########
site/content/in-dev/unreleased/rest-catalog-open-api.md:
##########
@@ -17,11 +17,11 @@
# specific language governing permissions and limitations
# under the License.
#
-title: 'Apache Iceberg OpenAPI'
-linkTitle: 'Iceberg OpenAPI'
+title: 'Apache Polaris and Iceberg Catalog OpenAPI'
+linkTitle: 'Catalog OpenAPI'
weight: 900
params:
show_page_toc: false
---
-{{< redoc-polaris "rest-catalog-open-api.yaml" >}}
+{{< redoc-polaris "generated/bundled-polaris-catalog-service.yaml" >}}
Review Comment:
A preview of the current page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #935:
URL: https://github.com/apache/polaris/pull/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Site's REST Catalog Spec Reference to Bundled Polaris + Iceberg API YAML [polaris]
Posted by "sfc-gh-ygu (via GitHub)" <gi...@apache.org>.
sfc-gh-ygu commented on PR #935:
URL: https://github.com/apache/polaris/pull/935#issuecomment-2634886396
Hi @jbonofre , the reverting doesn't work as well. Is there any change from Apache Infra so that the website put more security limit?
```
polaris-management-service/:1 Refused to load the script 'https://cdn.jsdelivr.net/npm/redoc@latest/bundles/redoc.standalone.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline' 'unsafe-eval' https://analytics.apache.org/". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org