You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cmhe <gi...@git.apache.org> on 2015/07/06 09:50:56 UTC
[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...
GitHub user cmhe opened a pull request:
https://github.com/apache/thrift/pull/542
THRIFT-1522: Fixes Memory leak by wrapping getaddrinfo into a class.
Sponsored-by: Roger Meier <r....@siemens.com>
Signed-off-by: Claudius Heine <ch...@denx.de>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmhe/thrift THRIFT-1522
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit 4828e52ffe6a8bd0cdd7c40b629143a5ec299e31
Author: Claudius Heine <ch...@denx.de>
Date: 2015-07-06T07:14:25Z
THRIFT-1522: Fixes Memory leak by wrapping getaddrinfo into a class.
Sponsored-by: Roger Meier <r....@siemens.com>
Signed-off-by: Claudius Heine <ch...@denx.de>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...
Posted by cmhe <gi...@git.apache.org>.
Github user cmhe commented on the pull request:
https://github.com/apache/thrift/pull/542#issuecomment-118848681
I moved TGetAddrInfoWrapper into its own C++ Module and integrated it into TNonblockingServer and TSocket: https://github.com/cmhe/thrift/commits/WrappedGetAddrInfo
Comments are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...
Posted by cmhe <gi...@git.apache.org>.
Github user cmhe commented on the pull request:
https://github.com/apache/thrift/pull/542#issuecomment-118833111
Maybe this can also be used in TNonblockingServer.cpp and TSocket.cpp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...
Posted by cmhe <gi...@git.apache.org>.
Github user cmhe commented on the pull request:
https://github.com/apache/thrift/pull/542#issuecomment-118762338
I have run "make cross" and "make check" without any unexpected errors.
Feedback is welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1522: Fixes Memory leak by wrapping ge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---