You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernardo Gomez Palacio <be...@gmail.com> on 2014/05/05 20:14:13 UTC
Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
Review request for mesos and Mesos ReviewBot.
Bugs: MESOS-1259
https://issues.apache.org/jira/browse/MESOS-1259
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
Diffs
-----
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
> On May 13, 2014, 12:27 a.m., Niklas Nielsen wrote:
> > src/java/src/org/apache/mesos/MesosSchedulerDriver.java, lines 75-77
> > <https://reviews.apache.org/r/21080/diff/1/?file=574748#file574748line75>
> >
> > Would you mind ending the sentences with period '.'?
> > Also, I feel like we should add a bit more context the the parameter descriptions.
> > Below, you reference the framework as "framework data" and the master as "master identifier". Can we do it coherently and call it, for example "
> > @param scheduler Scheduler implementation which callbacks are invoked upon scheduler events.
> > @param framework FrameworkInfo describing the current framework.
> > @param master The address to the currently active Mesos master.
> >
> > This is just a suggestion :)
> >
Will do.
- Bernardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review42790
-----------------------------------------------------------
On May 13, 2014, 12:27 a.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 12:27 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review42790
-----------------------------------------------------------
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/21080/#comment76705>
Would you mind ending the sentences with period '.'?
Also, I feel like we should add a bit more context the the parameter descriptions.
Below, you reference the framework as "framework data" and the master as "master identifier". Can we do it coherently and call it, for example "
@param scheduler Scheduler implementation which callbacks are invoked upon scheduler events.
@param framework FrameworkInfo describing the current framework.
@param master The address to the currently active Mesos master.
This is just a suggestion :)
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/21080/#comment76706>
Same as above.
- Niklas Nielsen
On May 12, 2014, 5:27 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 5:27 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review47767
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21080]
All tests passed.
- Mesos ReviewBot
On July 15, 2014, 6:48 a.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java 25f428e3695ce5c41997ad55a821a972e81452ed
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java 8e2cd882a92faa23877604264d3c577c082387fa
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 55520ea0559c3fd404049d60fe38efdddf90abdf
> src/java/src/org/apache/mesos/SchedulerDriver.java 32f4dd5972770ed2ce24eeee003f4f906a443786
> src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
> src/java/src/org/apache/mesos/state/LevelDBState.java d4e7aa9adbaac093065126a6337c6117317b9514
> src/java/src/org/apache/mesos/state/State.java ec354fe36c8f9931e20703ab16ac6a07830d9865
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated July 15, 2014, 6:48 a.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Applied style fixes suggested in RB
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files.
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java 25f428e3695ce5c41997ad55a821a972e81452ed
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java 8e2cd882a92faa23877604264d3c577c082387fa
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 55520ea0559c3fd404049d60fe38efdddf90abdf
src/java/src/org/apache/mesos/SchedulerDriver.java 32f4dd5972770ed2ce24eeee003f4f906a443786
src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
src/java/src/org/apache/mesos/state/LevelDBState.java d4e7aa9adbaac093065126a6337c6117317b9514
src/java/src/org/apache/mesos/state/State.java ec354fe36c8f9931e20703ab16ac6a07830d9865
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review44111
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21080]
All tests passed.
- Mesos ReviewBot
On May 16, 2014, 10:55 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 10:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review45844
-----------------------------------------------------------
Ship it!
Awesome Bernardo - sorry for the delay. Let us get this in.
src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/21080/#comment80840>
Please scan the patch for trailing spaces :-)
src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/21080/#comment80838>
Format is // TODO(vinod:
src/java/src/org/apache/mesos/Log.java
<https://reviews.apache.org/r/21080/#comment80836>
Capitalize first character here and everywhere else :-)
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/21080/#comment80837>
See comment above.
- Niklas Nielsen
On May 16, 2014, 3:55 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 3:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 16, 2014, 10:55 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
The {@inheritDoc} doesn't inherit the @deprecated tag, we are better without it in this case.
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files.
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 16, 2014, 10:40 p.m.)
Review request for mesos and Niklas Nielsen.
Summary (updated)
-----------------
[MESOS-1259]:Enrich the Java Docs in the src/java files.
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files.
Diffs
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 16, 2014, 10:39 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Consolidating all changes to this RR.
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description (updated)
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files.
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
> On May 15, 2014, 10:52 p.m., Niklas Nielsen wrote:
> > src/java/src/org/apache/mesos/Executor.java, lines 48-82
> > <https://reviews.apache.org/r/21080/diff/2/?file=582448#file582448line48>
> >
> > Thanks for expanding!
> > However, I am not sure that it useful to list the protobuf field descriptions here. How about referring to the mesos.proto file? It is not all the descriptions that works out of context of the field being described. But maybe that's just me.
> >
> > If not referring to the .proto, can we maybe condense it a bit?
> >
> > And finally:
> > s/ / /
Thanks Niklas.
1. Will wrap to 80, I was not sure about the wrapping for Java files thanks for pointing it out. (it is documented 70 for C++ files).
2. Right now we are not able to link to the protobuf file from the JDoc and I I think, for now, its good to provide this type of information (will condense it).
3. The unit of indentation should be 2 whitespaces then?
- Bernardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review43169
-----------------------------------------------------------
On May 15, 2014, 8:56 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 8:56 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review43169
-----------------------------------------------------------
Hey Bernardo,
Thanks for updating! Let us get this committed soon.
I had one issue with the comments for the registered callback.
Also, would you mind doing a scan so we can aim for line width 80? http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.4-column-limit
src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/21080/#comment77237>
Thanks for expanding!
However, I am not sure that it useful to list the protobuf field descriptions here. How about referring to the mesos.proto file? It is not all the descriptions that works out of context of the field being described. But maybe that's just me.
If not referring to the .proto, can we maybe condense it a bit?
And finally:
s/ / /
- Niklas Nielsen
On May 15, 2014, 1:56 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 1:56 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 15, 2014, 8:56 p.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 12, 2014, 5:27 p.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
Diffs
-----
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- MesosSchedulerDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/
-----------------------------------------------------------
(Updated May 5, 2014, 6:46 p.m.)
Review request for mesos and Mesos ReviewBot.
Changes
-------
Subtask of MESOS-1259
Bugs: MESOS-1302
https://issues.apache.org/jira/browse/MESOS-1302
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java
Diffs
-----
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
Diff: https://reviews.apache.org/r/21080/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio