You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/11/04 13:20:49 UTC
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 1:20 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review112808
-----------------------------------------------------------
src/examples/test_http_authenticator_module.cpp (line 35)
<https://reviews.apache.org/r/38950/#comment173300>
+ blank line
src/tests/http_authentication_tests.cpp (line 83)
<https://reviews.apache.org/r/38950/#comment173301>
Not needed.
src/tests/http_authentication_tests.cpp (line 143)
<https://reviews.apache.org/r/38950/#comment173303>
Parametized -> Parameterized
But parameterized is not actually the opposite of paremeterless.
- Bernd Mathiske
On Jan. 5, 2016, 1:39 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 1:39 a.m.)
>
>
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support for modularization of HTTP Authenticators.
>
> It includes an example of how to do it with the Basic HTTP Authenticator.
>
>
> Diffs
> -----
>
> include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
> include/mesos/module/http_authenticator.hpp PRE-CREATION
> src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
> src/examples/test_http_authenticator_module.cpp PRE-CREATION
> src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
> src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
> src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
> src/tests/http_authentication_tests.cpp PRE-CREATION
> src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
> src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
>
> Diff: https://reviews.apache.org/r/38950/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review112810
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Jan. 5, 2016, 2:34 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 2:34 a.m.)
>
>
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support for modularization of HTTP Authenticators.
>
> It includes an example of how to do it with the Basic HTTP Authenticator.
>
>
> Diffs
> -----
>
> include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
> include/mesos/module/http_authenticator.hpp PRE-CREATION
> src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
> src/examples/test_http_authenticator_module.cpp PRE-CREATION
> src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
> src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
> src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
> src/tests/http_authentication_tests.cpp PRE-CREATION
> src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
> src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
>
> Diff: https://reviews.apache.org/r/38950/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 11:27 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1
src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:43 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Till's requested changes.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review113061
-----------------------------------------------------------
Ship it!
This looks great Alexander - almost perfect :) !
src/master/constants.hpp (line 134)
<https://reviews.apache.org/r/38950/#comment173569>
s/Basic/basic/
src/tests/module.cpp (line 239)
<https://reviews.apache.org/r/38950/#comment173571>
s/http/HTTP/
src/tests/module.cpp (line 284)
<https://reviews.apache.org/r/38950/#comment173572>
s/http/HTTP/
s/teshttpauthenticator/testhttpauthenticator/
- Till Toenshoff
On Jan. 5, 2016, 4:17 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 4:17 p.m.)
>
>
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support for modularization of HTTP Authenticators.
>
> It includes an example of how to do it with the Basic HTTP Authenticator.
>
>
> Diffs
> -----
>
> include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
> include/mesos/module/http_authenticator.hpp PRE-CREATION
> src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
> src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
> src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
> src/examples/test_http_authenticator_module.cpp PRE-CREATION
> src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
> src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
> src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
> src/tests/http_authentication_tests.cpp PRE-CREATION
> src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
> src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
>
> Diff: https://reviews.apache.org/r/38950/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 5:17 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Fixed a wrong static function declaration.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 11:34 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Bernds review.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 10:39 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Update tests because of changes in previous review.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 10:23 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 1:58 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0
src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840
src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4
src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22
src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 3:45 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Bernds review.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb
src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review110216
-----------------------------------------------------------
include/mesos/authentication/http/basic_authenticator_factory.hpp (line 29)
<https://reviews.apache.org/r/38950/#comment170009>
Why isn't this in namespace `authentication`?
src/examples/test_http_authenticator_module.cpp (line 41)
<https://reviews.apache.org/r/38950/#comment170013>
Why aren't we using the factory here?
src/tests/http_authentication_tests.cpp (line 102)
<https://reviews.apache.org/r/38950/#comment170016>
Can you please be more specific about what functional testing and which libprocess tests?
src/tests/http_authentication_tests.cpp (line 129)
<https://reviews.apache.org/r/38950/#comment170018>
Exact same comment as above for a different test. Please make comments that differentiate the two.
- Bernd Mathiske
On Dec. 10, 2015, 6:32 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:32 a.m.)
>
>
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support for modularization of HTTP Authenticators.
>
> It includes an example of how to do it with the Basic HTTP Authenticator.
>
>
> Diffs
> -----
>
> include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
> include/mesos/module/http_authenticator.hpp PRE-CREATION
> src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb
> src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
> src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
> src/examples/test_http_authenticator_module.cpp PRE-CREATION
> src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
> src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
> src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
> src/tests/http_authentication_tests.cpp PRE-CREATION
> src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
> src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
>
> Diff: https://reviews.apache.org/r/38950/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review109153
-----------------------------------------------------------
src/examples/test_http_authenticator_module.cpp (lines 49 - 50)
<https://reviews.apache.org/r/38950/#comment168618>
s/a/an/
s/Authorizer/http authenticator/
src/master/constants.hpp (line 131)
<https://reviews.apache.org/r/38950/#comment168619>
s/Basic/basic/ ?
src/tests/module.cpp (line 216)
<https://reviews.apache.org/r/38950/#comment168617>
s/authorizer/authenticator/
- Till Toenshoff
On Dec. 10, 2015, 2:32 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 2:32 p.m.)
>
>
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support for modularization of HTTP Authenticators.
>
> It includes an example of how to do it with the Basic HTTP Authenticator.
>
>
> Diffs
> -----
>
> include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
> include/mesos/module/http_authenticator.hpp PRE-CREATION
> src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb
> src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
> src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
> src/examples/test_http_authenticator_module.cpp PRE-CREATION
> src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
> src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
> src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
> src/tests/http_authentication_tests.cpp PRE-CREATION
> src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
> src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
>
> Diff: https://reviews.apache.org/r/38950/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 3:32 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb
src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 11:24 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Fixed copyright notice in new files.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Dec. 7, 2015, 3:21 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759
src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Dec. 7, 2015, 2:33 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 04f42dc4f687e55c4e6758ef2f7c7096f1b1ec47
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 2:37 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Third round of reviews.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 04f42dc4f687e55c4e6758ef2f7c7096f1b1ec47
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 5:28 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Second round of reviews.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9
src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 04f42dc4f687e55c4e6758ef2f7c7096f1b1ec47
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 11:08 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Update dependencies.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9
src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 11:01 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Changes to take into account changes in the interface in previous reviews.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9
src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 5:02 a.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9
src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 38950: Http Authenticators can be loaded as
modules from mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 11:38 p.m.)
Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756
Repository: mesos
Description
-------
Adds support for modularization of HTTP Authenticators.
It includes an example of how to do it with the Basic HTTP Authenticator.
Diffs (updated)
-----
include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION
include/mesos/module/http_authenticator.hpp PRE-CREATION
src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9
src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330
src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION
src/examples/test_http_authenticator_module.cpp PRE-CREATION
src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2
src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09
src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69
src/tests/http_authentication_tests.cpp PRE-CREATION
src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2
src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f
Diff: https://reviews.apache.org/r/38950/diff/
Testing
-------
make check
Thanks,
Alexander Rojas