You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by markerickson-wf <gi...@git.apache.org> on 2016/05/25 18:19:02 UTC
[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1019
THRIFT-3842 Fix Dart generator for const structs
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
ref: https://issues.apache.org/jira/browse/THRIFT-3842
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1019.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1019
----
commit e79da1dfb4a9860f8c27707919bd6e102678af60
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-05-25T18:06:00Z
THRIFT-3842 Fix Dart generator for const structs
commit 07aa863c84366c404fdc0c7c8bca3bfb74c784d9
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-05-25T18:18:47Z
Remove unnecessary call to service_imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...
Posted by tylertreat-wf <gi...@git.apache.org>.
Github user tylertreat-wf commented on the pull request:
https://github.com/apache/thrift/pull/1019#issuecomment-221731564
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...
Posted by brianshannan-wf <gi...@git.apache.org>.
Github user brianshannan-wf commented on the pull request:
https://github.com/apache/thrift/pull/1019#issuecomment-221676733
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---