You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/05/21 19:22:09 UTC
[GitHub] pritidesai closed pull request #917: Resolves issue #916
pritidesai closed pull request #917: Resolves issue #916
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/917
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/deployers/manifestreader.go b/deployers/manifestreader.go
index c19fd689..220924dd 100644
--- a/deployers/manifestreader.go
+++ b/deployers/manifestreader.go
@@ -295,8 +295,13 @@ func (reader *ManifestReader) SetApis(ar []*whisk.ApiCreateRequest) error {
defer dep.mt.Unlock()
for _, api := range ar {
- dep.Deployment.Apis[api.ApiDoc.Action.Name] = api
+ apiPath := api.ApiDoc.ApiName + api.ApiDoc.GatewayBasePath + api.ApiDoc.GatewayRelPath + api.ApiDoc.GatewayMethod
+
+ // uniqueness issue when using action name as key as there can be multiple APIs pointing to same action.
+ // using apiPath instead as it is uniqueue
+ dep.Deployment.Apis[apiPath] = api
}
+
return nil
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services