You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:04:58 UTC

[GitHub] [rocketmq] jasonjavaYY commented on issue #5440: [code]is the refcount's set value correct?

jasonjavaYY commented on issue #5440:
URL: https://github.com/apache/rocketmq/issues/5440#issuecomment-1298185039

   I aggre with you, but the code is really confusing and may be misunderstood as "-1000" has special meaning.
   
   > IMO, the set operation mainly sets the `refCount` to negative so that cleanupOver can be forced after a timeout. So if you use +, the `refCount` might still be positive. (The way I understand it, it's probably better to just make `refCount` negative)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org