You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by gauravaradhye <gi...@git.apache.org> on 2015/06/05 13:56:55 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8542: Correcting test case in ...
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/360
CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py
The test in the test suite is checking that when the hosts are in maintenance state, then VPC created with start=False parameter should be in inactive state. However, this is incorrect.
VPC is in inactive state only after it is deleted. Hence the state of the VPC created when the hosts are in maintenance state is Enabled only.
Further, the VPC won't be deleted by any cleanup threads because it is in enabled state and not in inactive state. Remove the test case which asserts that VPC should be removed after cleanup interval.
Other changes:
Removed hard-coded services dict from the test case. Instead the test case will use the dict located at /marvin/config/test_data.py which is common for all test cases.
Logs:
Test VPC when host is in maintenance mode ... === TestName: test_01_create_vpc_host_maintenance | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 189.881s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gauravaradhye/cloudstack 8542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/360.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #360
----
commit 844a3bc167cdaa2e6b82444e587d9547f146c0e4
Author: Gaurav Aradhye <ga...@clogeny.com>
Date: 2015-06-05T09:05:56Z
CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8542: Correcting test case in ...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/360#issuecomment-109868949
Done with review changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8542: Correcting test case in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/360
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---