You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2017/03/09 20:15:38 UTC

svn commit: r1786233 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java

Author: tilman
Date: Thu Mar  9 20:15:38 2017
New Revision: 1786233

URL: http://svn.apache.org/viewvc?rev=1786233&view=rev
Log:
PDFBOX-3702: revert my own change; avoid ArrayIndexOutOfBoundsException, by Oliver Schmidtmer

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java?rev=1786233&r1=1786232&r2=1786233&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/CCITTFaxDecoderStream.java Thu Mar  9 20:15:38 2017
@@ -88,8 +88,8 @@ final class CCITTFaxDecoderStream extend
         
         this.fillOrder = fillOrder;
 
-        this.changesReferenceRow = new int[columns+1];
-        this.changesCurrentRow = new int[columns+1];
+        this.changesReferenceRow = new int[columns + 2];
+        this.changesCurrentRow = new int[columns + 2];
 
         switch (type) {
             case TIFFExtension.COMPRESSION_CCITT_MODIFIED_HUFFMAN_RLE:
@@ -189,10 +189,7 @@ final class CCITTFaxDecoderStream extend
 
                             runLength = decodeRun(white ? blackRunTree : whiteRunTree);
                             index += runLength;
-                            if (changesCurrentRowCount < changesCurrentRow.length)
-                            {
-                                changesCurrentRow[changesCurrentRowCount++] = index;
-                            }
+                            changesCurrentRow[changesCurrentRowCount++] = index;
                             break;
 
                         case VALUE_PASSMODE: