You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/31 19:37:38 UTC

[GitHub] piiswrong commented on a change in pull request #9256: fix link error for parallel rng

piiswrong commented on a change in pull request #9256: fix link error for parallel rng
URL: https://github.com/apache/incubator-mxnet/pull/9256#discussion_r159145857
 
 

 ##########
 File path: src/common/random_generator.h
 ##########
 @@ -47,9 +47,9 @@ template<typename DType>
 class RandGenerator<cpu, DType> {
  public:
   // at least how many random numbers should be generated by one CPU thread.
-  static const int kMinNumRandomPerThread = 64;
+  static const int kMinNumRandomPerThread;
 
 Review comment:
   use constexpr so that you don't need to define it separately

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services