[GitHub] [airflow] dstandish commented on a diff in pull request #27758: WIP - Enable trigger logging in webserver

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1055188602


##########
airflow/jobs/triggerer_job.py:
##########
@@ -368,8 +518,18 @@ async def run_trigger(self, trigger_id, trigger):
             # allow triggers a chance to cleanup, either in that case or if
             # they exit cleanly.
             trigger.cleanup()
+            self.close_handler(trigger)
 
-    # Main-thread sync API
+            # unsetting ctx_indiv_trigger var restores stdout logging
+            ctx_indiv_trigger.set(None)

Review Comment:
   i explored that. the thing with that is you need to store a token when you set it and then supply the token when resetting.  and i decided it's not worth the complexity, particularly because, if it _were_ set to something other than None, we wouldn't want to set it back to that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org