You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/05/21 03:09:34 UTC

[kudu-CR] KUDU-1884: Set sasl protocol name for the TxnSystemClient 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17480


Change subject: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: Set sasl_protocol_name for the TxnSystemClient

In clusters witha custom principal we need to set the
sasl_protocol_name on the embeded client within the
TxnSystemClient.

This logic matches that in server_base.cc for server
messenger configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M src/kudu/transactions/txn_system_client.cc
2 files changed, 32 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 17:36:23 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 5:

> You may need to rebase this on https://gerrit.cloudera.org/#/c/17499/

It's already rebased, AFAIK: 35de43051b65c8eab0f348bfd7c8a0d6e49c8067 is the parent commit for this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 15:58:47 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc
File src/kudu/transactions/txn_system_client.cc:

http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc@72
PS5, Line 72: DECLARE_string(keytab_file);
> are these used?
Nice catch: indeed, there are not used -- not sure why there are here, probably left-overs from previous iterations on this patch.

Removed.



-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 17:24:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 17:52:15 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: Set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@9
PS2, Line 9: witha
with a


http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@10
PS2, Line 10: embeded
embedded


http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@13
PS2, Line 13: This logic matches that in server_base.cc for server
            : messenger configuration.
Does it make sense to add a test, at least catch regressions once the overlooked place for the kerberos principal customization is found?  It seems a small end-to-end scenario might be added into client-test.cc or txn_write_ops-itest.cc



-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 May 2021 04:42:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: set sasl_protocol_name for the TxnSystemClient

In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.

This logic matches that in server_base.cc for server messenger
configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Reviewed-on: http://gerrit.cloudera.org:8080/17480
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 140 insertions(+), 61 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 17:49:02 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#6) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: set sasl_protocol_name for the TxnSystemClient

In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.

This logic matches that in server_base.cc for server messenger
configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 139 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/6
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-1884: Set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@13
PS2, Line 13: This logic matches that in server_base.cc for server
            : messenger configuration.
> Does it make sense to add a test, at least catch regressions once the overl
Probably, security-itest.cc might be even a better place for a new test scenario.



-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 21 May 2021 04:43:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP: KUDU-1884: Set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17480

to look at the new patch set (#3).

Change subject: WIP: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................

WIP: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient

In clusters witha custom principal we need to set the
sasl_protocol_name on the embeded client within the
TxnSystemClient.

This logic matches that in server_base.cc for server
messenger configuration.

WIP: Because of testing challenges.
TODO: Remove all the hard coded proto name calls

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
12 files changed, 64 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP: KUDU-1884: Set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: WIP: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................

WIP: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient

In clusters witha custom principal we need to set the
sasl_protocol_name on the embeded client within the
TxnSystemClient.

This logic matches that in server_base.cc for server
messenger configuration.

WIP: Because of testing challenges.
TODO: Remove all the hard coded proto name calls

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
12 files changed, 47 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 16:04:24 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: Set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17480

to look at the new patch set (#2).

Change subject: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: Set sasl_protocol_name for the TxnSystemClient

In clusters witha custom principal we need to set the
sasl_protocol_name on the embeded client within the
TxnSystemClient.

This logic matches that in server_base.cc for server
messenger configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/transactions/txn_system_client.cc
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#5) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: set sasl_protocol_name for the TxnSystemClient

In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.

This logic matches that in server_base.cc for server messenger
configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 141 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 8: Code-Review+2

Carrying over Attila's and Grant's +2 from PS6 and PS7.


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 19:24:51 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 5: Code-Review+1

You may need to rebase this on https://gerrit.cloudera.org/#/c/17499/


-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 15:51:38 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc
File src/kudu/transactions/txn_system_client.cc:

http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc@72
PS5, Line 72: DECLARE_string(keytab_file);
are these used?



-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 25 May 2021 16:34:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1884: set sasl protocol name for the TxnSystemClient

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#8) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/17480 )

Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient
......................................................................

KUDU-1884: set sasl_protocol_name for the TxnSystemClient

In clusters with a custom principal we need to set the
sasl_protocol_name on the embedded client within the TxnSystemClient.

This logic matches that in server_base.cc for server messenger
configuration.

Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_txn.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
13 files changed, 140 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17480/8
-- 
To view, visit http://gerrit.cloudera.org:8080/17480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf
Gerrit-Change-Number: 17480
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)