[jira] [Commented] (SAMZA-879) TestSystemConsumers has tests with @Test annotation

["Branislav Cogic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183054#comment-15183054 ] 

Branislav Cogic commented on SAMZA-879:
---------------------------------------

It seems that mock consumers class CustomPollResponseSystemConsumer was not modeled and tested properly. SystemConsumers class is working as expected. Tests are passing now.
The patch is attached.
Here is a RB link: https://reviews.apache.org/r/44452/

> TestSystemConsumers has tests with @Test annotation
> ---------------------------------------------------
>
>                 Key: SAMZA-879
>                 URL: https://issues.apache.org/jira/browse/SAMZA-879
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Navina Ramesh
>            Assignee: Branislav Cogic
>            Priority: Minor
>              Labels: newbie++
>         Attachments: SAMZA-879.0.patch
>
>
> It has somehow gone unnoticed that the TestSystemConsumers class has 2 tests without @Test annotation. 
> I am not sure about the history of this. However, these tests seem to fail. We should get it fixed, if appropriate. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)